372411 - command line interface fails: NSLDIF32V6.0 could not be found

Status: RESOLVED FIXED

(Directory Graveyard :: LDAP C SDK, defect)

Description

[Noriko Hosoi]

I built Mozilla LDAP C SDK from the CVS tip to test the new NSPR ipv6 patch (Proposed patch (for NSPR_4_6_4_RTM <https://bugzilla.mozilla.org/attachment.cgi?id=255985>) last week.

When I tried to run the command line interface (e.g., ldapsearch), I got this error:
   The dynamic link library NSLDIF32V6.0 could not be found in the
   specified path ....

I've noticed directory/c-sdk/ldap/libraries/msdos/winsock/nsldif32.tdf and nsldif32.def were added to CVS recently and it looks to me the order of the version formats are swapped.  At least, once I made the change and removed nsldif32.def, and rebuilt LDAP C SDK, the command line interface started working.  (note: nsldif32.def is created in the make process from nsldif32.tdf, so we don't have to have it in CVS, I believe...)

   Index: nsldif32.tdf
   ===================================================================
   RCS file:
   /cvsroot/mozilla/directory/c-sdk/ldap/libraries/msdos/winsock/nsldif32.tdf,v
   retrieving revision 5.1
   diff -t -w -U 4 -r5.1 nsldif32.tdf
   --- nsldif32.tdf        15 Jan 2007 21:19:25 -0000      5.1
   +++ nsldif32.tdf        2 Mar 2007 19:01:18 -0000
   @@ -34,11 +34,11 @@
    ; the terms of any one of the MPL, the GPL or the LGPL.
    ;
    ; ***** END LICENSE BLOCK *****

   -LIBRARY         NSLDIF32V$1
   +LIBRARY         NSLDIF32V$2
    DESCRIPTION     'Lightweight Directory Access Protocol LDIF Client
   API for 32-bit Windows'
   -VERSION         $2
   +VERSION         $1
    HEAPSIZE        4096

Comment 1

[Noriko Hosoi]

Attachment: cvs diff mozilla/directory/c-sdk/ldap/libraries/msdos/winsock/nsldif32.tdf

Plus I'd like to remove mozilla/directory/c-sdk/ldap/libraries/msdos/winsock/nsldif32.def from the CVS tree.

Comment 2

[Rich Megginson]

Fix looks good.

Looks like nsldap32.def, nsldappr32.def, nsldapssl32.def, and nsldif32.def are all regenerated if they do not exist.  So I'm not sure why they were ever checked into CVS in the first place.  Perhaps we just forgot to remove them when the code to generate them from the .tdf files was added.  I'd rather have some confirmation from Mark or Anton before removing them.  But I think it's ok to remove them.

Comment 3

[Mark Smith [:mcs]]

(In reply to comment #2)
> Looks like nsldap32.def, nsldappr32.def, nsldapssl32.def, and nsldif32.def are
> all regenerated if they do not exist.  So I'm not sure why they were ever
> checked into CVS in the first place.

A while ago, they were not automatically generated on Windows.  If they always are now (and I think they are), then we can cvs remove all the .def files.  Anton, are you OK with that?

Comment 4

[Mark Smith [:mcs]]

Comment on attachment 257051 [details] [diff] [review]
cvs diff mozilla/directory/c-sdk/ldap/libraries/msdos/winsock/nsldif32.tdf

The change looks good.  I am not sure how this one .tdf file got "out of sync" with the others.

But I do not have superreview privileges (needed if this code will go into one of the Mozilla clients such as Thunderbird soon).

Comment 5

[Anton Bobrov]

i believe they are generated only with autoconf build but never with old
style build tho i'm not against removing them since supporting two diff
build systems and keeping them in sync doesnt worth it, kinda adds up to 
confusion like in this case and a wee bit messy in general me thinks.

Comment 6

[Noriko Hosoi]

Thanks for your comments, Anton!

I tested the old style build after removing msdos/winsock/*.def files, then the build failed like this:
gmake.exe[3]: *** No rule to make target `../msdos/winsock/nsldappr32.def', needed by `WINNT5.0_DBG.OBJ/nsldappr32v60.dll'.  Stop.

Not to break the old style build, I'm going to checkin the derived nsldif32.def with nsldif32.tdf.
Thanks,
--noriko

Comment 7

[Noriko Hosoi]

In addition to the attachment (id=257051), I'm going to commit this file, which is automatically generated in the autotool build not to break the old style build.
Index: nsldif32.def
===================================================================
RCS file: /cvsroot/mozilla/directory/c-sdk/ldap/libraries/msdos/winsock/nsldif32.def,v
retrieving revision 5.1
diff -t -w -U4 -r5.1 nsldif32.def
--- nsldif32.def        15 Jan 2007 21:19:25 -0000      5.1
+++ nsldif32.def        7 Mar 2007 22:11:00 -0000
@@ -34,11 +34,11 @@
 ; the terms of any one of the MPL, the GPL or the LGPL.
 ;
 ; ***** END LICENSE BLOCK *****

-LIBRARY         NSLDIF32V6.0
+LIBRARY         NSLDIF32V60
 DESCRIPTION     'Lightweight Directory Access Protocol LDIF Client API for 32-bit Windows'
-VERSION         60
+VERSION         6.0
 HEAPSIZE        4096

Comment 8

[Rich Megginson]

Ok.

Comment 9

[Noriko Hosoi]

Attachment: cvs commit message

Reviewed by Rich, Mark, and Anton.  (Thank you so much!)

Checked in into HEAD.