372426 - [FIX]automatic page redirection broken on 64-bit build

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P1)

Description

[Alex Romosan]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9a3pre) Gecko/20070302 Mozilla/1.5a
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9a3pre) Gecko/20070302 Mozilla/1.5a

for the last month or so (the last checkout from cvs that i had working was on February 7, 2007) automatic page redirect has stopped working for my 64-bit cvs seamonkey build (works fine for 32-bit builds). I think the patch to Bug 83265 (Add a way to disable HTTP-EQUIV=refresh) broke it but i haven't been able to come up with a fix.

Reproducible: Always

Steps to Reproduce:
1. go to a page that redirects to another page

Actual Results:  
first page displays forever, browser never redirects to the intended target.

Comment 1

[Boris Zbarsky [:bzbarsky]]

I don't think this is a core issue...

Comment 2

[Boris Zbarsky [:bzbarsky]]

So as far as I can tell, nsBrowserStatusFilter::OnRefreshAttempted returns a random value if mListener doesn't QI to nsIWebProgressListener2.  Or am I missing something?

This doesn't bite in Firefox presumably because whatever listener (nsBrowserStatusHandler?) is involved was changed to implement that interface.  But in Seamonkey that wasn't done.  So nsBrowserStatusFilter probably needs fixing.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch to test

Does this fix the bug?

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 257267 [details] [diff] [review]
Patch to test

(I haven't tested this)

Comment 5

[Boris Zbarsky [:bzbarsky]]

I haven't either -- I don't have a 64 bit system.  Alex, does this fix things for you?

Comment 6

[Alex Romosan]

(In reply to comment #5)

i've tested it remotely since my 64-bit machine is at work and it seems to work. i'll try again tomorrow when i sit in front of my desktop but i expect it to work as well. so, this probably fixes the bug.

Comment 7

[Alex Romosan]

i've also tested it locally and page redirection works again so i would say the fix is good. thanks.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 257267 [details] [diff] [review]
Patch to test

Mark is apparently no longer active.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Checked in.