372531 - "match" should be a generic function in Bugzilla::Object

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Max Kanat-Alexander]

The current Bugzilla::Field::match function would be useful for all of our objects, I think. At the very least, I had a use for it in some customizations I did, and so I've already done this, I just have to pull out the patch and attach it.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

This is the initial version, as I implemented it. However, it includes the ability for match() to match NULL and NOT NULL, which we don't need yet, so we shouldn't include that upstream.

Comment 2

[Max Kanat-Alexander]

Comment on attachment 257179 [details] [diff] [review]
v1

Actually, I'll need the NOT NULL and NULL stuff soon for the "fields that control other fields." If you want me to take it out and submit another patch, though, I'd also be happy to do that.

Comment 3

[Frédéric Buclin]

Comment on attachment 257179 [details] [diff] [review]
v1

>Index: Bugzilla/Object.pm

>+    my @join;
>+    foreach my $join_def (@{$class->MATCH_JOIN}) {
>+        my %def = %$join_def;
>+        my ($f_table, $from, $to) = @def{qw(table from to)};
>+        push(@join, "LEFT JOIN $f_table ON $table.$from = $f_table.$to");
>+    }
>+    my $join_sql = join("\n", @join);

Per our discussion on IRC, this should go away.

Comment 4

[Max Kanat-Alexander]

Attachment: v2

Okay, removed that code and added POD.

Comment 5

[Frédéric Buclin]

Comment on attachment 261574 [details] [diff] [review]
v2

>Index: Bugzilla/Object.pm

>+        if ($value eq NOT_NULL) {

Next time, please do some minimal tests first. :)

Bareword "NOT_NULL" not allowed while "strict subs" in use at Bugzilla/Object.pm line 153, <DATA> line 225.
Bareword "IS_NULL" not allowed while "strict subs" in use at Bugzilla/Object.pm line 153, <DATA> line 225.

You have to |use Bugzilla::Constants| in Object.pm in order to use NOT_NULL and IS_NULL.


r=LpSolit with this line added.

Comment 6

[Max Kanat-Alexander]

Ah, thanks for catching that. :-) I copied this code out of NASA code, and I must have just missed that block.

Checking in Bugzilla/Constants.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Constants.pm,v  <--  Constants.pm
new revision: 1.70; previous revision: 1.69
done
Checking in Bugzilla/Field.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Field.pm,v  <--  Field.pm
new revision: 1.26; previous revision: 1.25
done
Checking in Bugzilla/Object.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Object.pm,v  <--  Object.pm
new revision: 1.15; previous revision: 1.14
done