372546 - Mark pipe input/output streams as threadsafe

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Jeff Walden [:Waldo]]

In my work on the HTTP server in bug 370245, I'm getting the following message printed to console:

!!!!! XPConnect wrapper thread use error...
  XPConnect WrappedNative is being accessed on multiple threads but the underlying native xpcom object does not have a nsIClassInfo with the 'THREADSAFE' flag set
  wrapper: [xpconnect wrapped nsIOutputStream @ 0x8114230 (native @ 0x80e93d8)]

The JS stack indicates that the wrapper is on the output stream created from |socketTransport.openOutputStream(OPEN_BLOCKING, 0, 0)|.  This stream is from a pipe, so nsPipeOutputStream needs to be marked as threadsafe.

I hope to get to this soon, but classes may get in the way.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Patch

This would also fix bug 365043.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 258084 [details] [diff] [review]
Patch

+NS_IMPL_CI_INTERFACE_GETTER3(nsPipeOutputStream,

how about putting those near the IMPL_ISUPPORTS/IMPL_QUERY_INTERFACE lines, so that it's more likely that people will change both when making this class implement a new interface?

Comment 3

[Jeff Walden [:Waldo]]

Attachment: Move QI impls. up next to the CI impls

(In reply to comment #2)
> +NS_IMPL_CI_INTERFACE_GETTER3(nsPipeOutputStream,
> 
> how about putting those near the IMPL_ISUPPORTS/IMPL_QUERY_INTERFACE lines, so
> that it's more likely that people will change both when making this class
> implement a new interface?

Good point; I should have seen this, given how difficult it was to find the QI impls to change them.  I moved the QI implementations up to the very top of each one's section, so hopefully future readers can find/sync them more easily.

Comment 4

[Jeff Walden [:Waldo]]

Fixed.