Closed Bug 372573 Opened 13 years ago Closed 13 years ago

NS_NO_INTERFACE should be NS_NOINTERFACE

Categories

(Calendar :: Internal Components, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Sunbird 0.5

People

(Reporter: BenB, Assigned: mattwillis)

References

()

Details

Attachments

(1 file)

/extensions/webdav/tests/davshell.js,
    * line 88 -- throw Components.interfaces.NS_NO_INTERFACE;
/calendar/providers/caldav/calDavCalendar.js,
    * line 1055 -- throw Components.interfaces.NS_NO_INTERFACE;
/calendar/providers/ics/calICSCalendar.js,
    * line 927 -- throw Components.interfaces.NS_NO_INTERFACE;

Please fix all 3 instances, not just in your component. Thanks,
After looking at the code, I think it should be NS_ERROR_NO_INTERFACE to be clearer that it is indeed an error and is something we want to throw on.

(Technically, NS_ERROR_NO_INTERFACE is #defined as NS_NOINTERFACE in nsError.h so it's really only a readability difference)
Assignee: nobody → lilmatt
Status: NEW → ASSIGNED
Attachment #257356 - Flags: first-review?(ctalbert.moz)
Status: ASSIGNED → NEW
Component: Provider: CalDav → Internal Components
OS: Linux → All
Hardware: PC → All
Target Milestone: --- → Sunbird 0.5
Status: NEW → ASSIGNED
Whiteboard: [patch in hand][needs review ctalbert]
Comment on attachment 257356 [details] [diff] [review]
s/NS_NO_INTERFACE/NS_ERROR_NO_INTERFACE/g

r = ctalbert looks fine
Attachment #257356 - Flags: first-review?(ctalbert.moz) → first-review+
Attachment #257356 - Flags: second-review?(jminta)
Attachment #257356 - Flags: second-review?(jminta) → second-review+
Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [patch in hand][needs review ctalbert]
You need to log in before you can comment on or make changes to this bug.