372579 - Elements referring to non-existent patterns are not updated when pattern becomes available

Status: RESOLVED DUPLICATE of bug 455984

(Core :: SVG, defect)

Description

[Jesse Ruderman]

When I add a <svg:pattern>, elements already in the document that refer to that pattern's ID are not updated.  Instead, they remain black.

Comment 1

[Jesse Ruderman]

Attachment: testcase A: add a pattern to the document

Comment 2

[Jesse Ruderman]

Bizarrely, when I navigate away (e.g. by clicking the Home button), the pattern suddenly shows up just before my Home page loads.

Comment 3

[Jesse Ruderman]

Oh, I bet that's just making it repaint.  Resizing the window makes the pattern appear too.

Comment 4

[Jesse Ruderman]

Attachment: testcase B: change the ID of a pattern to match the reference

Comment 5

[Robert Longson [:longsonr]]

Basically the same as bug 344258.

Comment 6

[Jesse Ruderman]

I still see this bug on trunk.

Comment 7

[Jesse Ruderman]

WFM, Mac trunk debug.  Yay?

Comment 8

[Robert Longson [:longsonr]]

Testcase A only works intermittently for me on Windows. Reload and sometimes you get just a black rectangle. Testcase B seems to be OK.

Comment 9

[Jesse Ruderman]

No longer WFM -- I get black rectangles for both testcase.  I'm still using Mac trunk debug.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I'm working on this.

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

OK, I've got a fix for this in my tree now. I'll submit it when more of that tree has landed on trunk. My fix also handles gradients, and handles cases where patterns 'inherit' from other patterns which only become available later.

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

-- Don't use frame state bits to track whether the effects properties exist; use the style data for a short-circuit check instead (this is really for the future extension to have effects on non-SVG frames, but it's convenient to do it here while I refactor the effect property code)

-- Make nsSVGPropertyBase use an embedded subclass of nsReferencedElement so that changes to the canonical element for a given ID are tracked

-- Fix clip-path and mask invalidation bugs when an element is removed from the document. I realize the ParentChainChanged methods can be shared, I'll do that in a followup patch.

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 330883 [details] [diff] [review]
fix

oops, this is the wrong bug for this patch