372583 - MozBuild::Util::RunShellCommand doesn't return signal name or number

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Andrew Schultz]

RunShellCommand is supposed to return the signal name as sigName.  But it never figures out what the signal name is.  It gets the signal number, but doesn't return it.

It apparently needs something like build-seamonkey-utils's signal_name
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/tools/tinderbox/build-seamonkey-util.pl&rev=1.351#1605

Comment 1

[J. Paul Reed [:preed]]

Attachment: Fixes a couple of these issues

-- Make sure we don't clobber any other filehandles called "LOGFILE"
-- make sure the sigNum we return really is the signal number
-- Handle dumped core appropriately (stolen from the patch for bug 372582)

I'm not implementing sig_name in this patch because arguably it's not RunShellCommand()s responsibility to come up with that information.

I believe I omitted it previously because the Config module wasn't installed on all the build machines we needed it to be... I... think.

I wouldn't be opposed to adding a GetSigName() function to Util.pm, though.

Comment 2

[J. Paul Reed [:preed]]

Checking in Util.pm;
/cvsroot/mozilla/tools/release/MozBuild/Util.pm,v  <--  Util.pm
new revision: 1.15; previous revision: 1.14
done