Closed Bug 372768 Opened 17 years ago Closed 17 years ago

{inc}Setting nowrap attribute dynamically does not change layout like it should

Categories

(Core :: Layout: Tables, defect)

Product:
Core
Component:
Layout: Tables
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jruderman, Assigned: sharparrow1)

References

Details

(Keywords: testcase)

Attachments

(3 files)

372768-1.html
234 bytes, text/html
Details
372768-1-ref.html
140 bytes, text/html
Details
Patch
1.31 KB, patch
bzbarsky
: review+
dbaron
: superreview+
Details | Diff | Splinter Review 
The testcase is based on reftests/bugs/362594-1a.html.  Quirks-only?
Attached file 372768-1.html — 
If you use DOM Inspector to remove the <BODY> and put it back, you'll see the table's width change.
Attached file 372768-1-ref.html — 

    
    

    
  
So the issue is that adding the nowrap attribute to a table cell with a fixed width in quirks mode doesn't change the white-space value but _does_ effectively change the min-width.  Which means we need to dirty the intrinsic widths on all ancestors of that frame, basically...

Unfortunately, I don't see a great place to do this.  nsTableCellFrame::AttributeChanged is one option, I guess...
Flags: in-testsuite?
Summary: Setting nowrap attribute dynamically does not change layout like it should → {inc}Setting nowrap attribute dynamically does not change layout like it should

    
  
Blocks: refdyn

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch
        — 
          — Splinter Review
      

    


  
Patch per bz's suggestion.
Assignee: nobody → sharparrow1
Status: NEW → ASSIGNED

        Attachment #270455 -
        Flags: review?(bzbarsky)

    
    

    
  
Comment on attachment 270455 [details] [diff] [review]
Patch

Looks reasonable, but it'd be good to have an impartial observer (dbaron, I would suggest) sr.

        Attachment #270455 -
        Flags: review?(bzbarsky) → review+

    
    

    
  
Comment on attachment 270455 [details] [diff] [review]
Patch

sr=dbaron, but please add a comment to BasicTableLayoutStrategy.cpp pointing to this code as well.

        Attachment #270455 -
        Flags: superreview+

    
    

    
  
Checked in (with added comment to BasicTableLayoutStrategy).
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED

    
    

    
  
Eli, want to check in the test attached to this bug too?

    
    

    
  
Checked in Jesse's reftest.
Flags: in-testsuite? → in-testsuite+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: