Closed
Bug 372776
Opened 17 years ago
Closed 17 years ago
Inserting zero-colspan TD causes incorrect rendering (renders as if colspan were 1)
Categories
(Core :: Layout: Tables, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: bernd_mozilla)
References
Details
(Keywords: testcase)
Attachments
(3 files)
532 bytes,
text/html
|
Details | |
292 bytes,
text/html
|
Details | |
1.14 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
This testcase is based on reftests/table-dom/appendCellsZeroColspan-ref.html. In fact, it looks like what appendCellsZeroColspan.html tries to test is pretty much the same thing this testcase tests, so I'm not sure why this fails while appendCellsZeroColspan.html passes.
Reporter | ||
Comment 1•17 years ago
|
||
Reporter | ||
Comment 2•17 years ago
|
||
Reporter | ||
Updated•17 years ago
|
Summary: Inserting zero-colspan TD causes incorrect rendering → Inserting zero-colspan TD causes incorrect rendering (renders as if colspan were 1)
expandcells inserts a zerocolspan but does not mark it. to do grep for SetZeroColSpan(PR_TRUE) verify that aMap.mTableFrame.SetHasZeroColSpans(PR_TRUE); aMap.mTableFrame.SetNeedColSpanExpansion(PR_TRUE); are called in the vicinity if necessary
Assignee: nobody → bernd_mozilla
Attachment #257537 -
Flags: superreview?(bzbarsky)
Attachment #257537 -
Flags: review?(bzbarsky)
Comment 5•17 years ago
|
||
Comment on attachment 257537 [details] [diff] [review] patch Makes sense. r+sr=bzbarsky
Attachment #257537 -
Flags: superreview?(bzbarsky)
Attachment #257537 -
Flags: superreview+
Attachment #257537 -
Flags: review?(bzbarsky)
Attachment #257537 -
Flags: review+
marking so
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 8•17 years ago
|
||
Is the reftest pair in this bug good? Should it go in bugs/ or table-dom/?
the reftest pair is good it, should go int table dom as insertCellsZeroColspan.html
Reporter | ||
Comment 10•17 years ago
|
||
I checked the reftest in a few hours ago.
Flags: in-testsuite? → in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•