372787 - erroneous block comment for ssl3_DestroySSL3Info

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P4)

Description

[Tammy]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6
Build Identifier: 

/* Called from ssl_FreeSocket() in sslsock.c */
void
ssl3_DestroySSL3Info(sslSocket *ss)

According to the block cooment, shouldn't ssl3_DestroySSL3Info() be called from 
ssl_FreeSocket()?

I found it iss called from ssl_FreeSocket() from two path, but not the following one.

call chain: SSL_ImportFD -> ssl_NewSocket  -> ssl_DestroySocketContents 

The two call chains that follow the comment are:
SSL_ImportFD -> ssl_FreeSocket -> ssl_DestroySocketContents
ssl_Accept -> ssl_FreeSocket -> ssl_DestroySocketContents


Reproducible: Always

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

ssl_DestroySocketContents unconditionally calls ssl3_DestroySSL3Info.
The block comment should be updated to say that.

ssl_FreeSocket unconditionally calls ssl_DestroySocketContents.
ssl_NewSocket only calls ssl_DestroySocketContents upon failure.

I think I should combine this bug with bug 369802.  

We shuold not do a checkin specifically to correct this comment, but the
next time we need to modify that file, we should correct this comment.

Comment 2

[:Cykesiopka]

This was done as part of Bug 373276:
  https://hg.mozilla.org/projects/nss/diff/8c957268885e/security/nss/lib/ssl/ssl3con.c#l1.400
  (Or if preferred: http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/security/nss/lib/ssl&command=DIFF&root=/cvsroot&file=ssl3con.c&rev1=1.100&rev2=1.101#15 )