372802 - Some source files have line ending inconsistencies

Status: NEW

(Core :: General, defect)

Description

[[e-mail]]

Attachment: These are all CR deletion changes only.

I have divided CVS files into various classifications:
1. Really binary files e.g. images
2. Files that are binary for testing mixed line endings
3. Files that are marked as text but contain mixed line endings
4. Text files
I want to eliminate class 3 by either reclassifying as class 2 or fixing them.

Comment 1

[Simon Montagu :smontagu]

Comment on attachment 257491 [details] [diff] [review]
These are all CR deletion changes only.

r=me on the extensions/universalchardet files. 

Are you making the changes manually or with a script? If the latter, why don't you just get someone (brendan?) to review the script and give rs for making changes with it?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 257491 [details] [diff] [review]
These are all CR deletion changes only.

I'm not sure which files you want me to review (sayrer and bsmedberg have the feeds and toolkit parts covered, I think), but r=me on the toolkit part anyways.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

rubberstamp=me on whatever files you think I can rubberstamp

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 257491 [details] [diff] [review]
These are all CR deletion changes only.

>Index: parser/htmlparser/tests/html/40809_CR.html

I'm not sure this change is correct -- the bug appears to be testing files that only have CRs (and no newlines).

Other than that, this looks fine.

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 257491 [details] [diff] [review]
These are all CR deletion changes only.

r=dveditz for xpinstall

Comment 6

[Doug Turner (:dougt)]

Comment on attachment 257491 [details] [diff] [review]
These are all CR deletion changes only.

what roc said.