Some source files have line ending inconsistencies

NEW
Unassigned

Status

()

Core
General
--
trivial
11 years ago
9 years ago

People

(Reporter: neil@parkwaycc.co.uk, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

111.69 KB, patch
Bienvenu
: review+
neil@parkwaycc.co.uk
: review?
Darin Fisher
dougt
: review+
Gavin
: review+
timeless
: review+
Benjamin Smedberg
: review+
smontagu
: review+
mrbkap
: review+
Robert Sayre
: review+
roc
: review+
dveditz
: review+
Details | Diff | Splinter Review
(Reporter)

Description

11 years ago
Created attachment 257491 [details] [diff] [review]
These are all CR deletion changes only.

I have divided CVS files into various classifications:
1. Really binary files e.g. images
2. Files that are binary for testing mixed line endings
3. Files that are marked as text but contain mixed line endings
4. Text files
I want to eliminate class 3 by either reclassifying as class 2 or fixing them.
(Reporter)

Updated

11 years ago
Attachment #257491 - Attachment description: Proposed patch → These are all CR deletion changes only.
Attachment #257491 - Flags: review?(timeless)
Attachment #257491 - Flags: review?(smontagu)
Attachment #257491 - Flags: review?(sayrer@
Attachment #257491 - Flags: review?(mrbkap)
Attachment #257491 - Flags: review?(gavin.sharp)
Attachment #257491 - Flags: review?(dougt)
Attachment #257491 - Flags: review?(darin.moz)
Attachment #257491 - Flags: review?(bienvenu)
Attachment #257491 - Flags: review?(benjamin)
Comment on attachment 257491 [details] [diff] [review]
These are all CR deletion changes only.

r=me on the extensions/universalchardet files. 

Are you making the changes manually or with a script? If the latter, why don't you just get someone (brendan?) to review the script and give rs for making changes with it?
Attachment #257491 - Flags: review?(smontagu) → review+

Updated

11 years ago
Attachment #257491 - Flags: review?(bienvenu) → review+
Comment on attachment 257491 [details] [diff] [review]
These are all CR deletion changes only.

I'm not sure which files you want me to review (sayrer and bsmedberg have the feeds and toolkit parts covered, I think), but r=me on the toolkit part anyways.
Attachment #257491 - Flags: review?(gavin.sharp) → review+

Updated

11 years ago
Attachment #257491 - Flags: review?(sayrer) → review+
rubberstamp=me on whatever files you think I can rubberstamp

Updated

11 years ago
Attachment #257491 - Flags: review?(benjamin) → review+
Comment on attachment 257491 [details] [diff] [review]
These are all CR deletion changes only.

>Index: parser/htmlparser/tests/html/40809_CR.html

I'm not sure this change is correct -- the bug appears to be testing files that only have CRs (and no newlines).

Other than that, this looks fine.
Attachment #257491 - Flags: review?(mrbkap) → review+

Updated

11 years ago
Attachment #257491 - Flags: review?(timeless) → review+
Comment on attachment 257491 [details] [diff] [review]
These are all CR deletion changes only.

r=dveditz for xpinstall
Attachment #257491 - Flags: review?(dveditz) → review+

Updated

9 years ago
Attachment #257491 - Flags: review?(doug.turner) → review+

Comment 6

9 years ago
Comment on attachment 257491 [details] [diff] [review]
These are all CR deletion changes only.

what roc said.
You need to log in before you can comment on or make changes to this bug.