Remove themes pane from preferences in suiterunner builds.

RESOLVED FIXED

Status

SeaMonkey
Preferences
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

After, or at the time of, the xpfe to toolkit switch over on trunk we need to remove the themes pane from the preferences window as it'll no longer be required.

Note: this does *not* mean we're near to being ready to switch over.

The xpfe builds still require the themes pane, and to save having to ifdef xul and js files etc, we've decided to leave xpfe builds along in this respect and apply the patch (that I'll attach later) at the time of the change over.

I'm putting it here mainly for reference (so its ready when we need it) and if anyone wants to test it (not that it affects much).

Comment 1

11 years ago
It is view in right parts vindow:

XML Parsing Error: undefined entity
Location: chrome://communicator/content/pref/pref-themes.xul
Line Number 109, Column 31:  <label class="small-margin"><html:a href="&getNewThemesURL;" id="themesLink"
Depends on: 335154
Created attachment 258964 [details] [diff] [review]
Removes the themes pane.

Like I said in comment 0, this patch removes the themes pref pane from all SeaMonkey builds. We won't be implementing this until the time we switch to suiterunner on trunk (bug 328887) but if anyone wishes to test/run with this, feel welcome. I'm putting it here so its ready for when its needed.
Comment on attachment 258964 [details] [diff] [review]
Removes the themes pane.

We're not going to land this until the switch, but I'd like to get reviews on it so once we're ready to switch we can land this at the same time.
Attachment #258964 - Flags: superreview?(neil)
Attachment #258964 - Flags: review?(neil)

Updated

10 years ago
Attachment #258964 - Flags: superreview?(neil) → superreview+

Comment 4

10 years ago
Comment on attachment 258964 [details] [diff] [review]
Removes the themes pane.

Doesn't the Languages panel need to go too?
Attachment #258964 - Flags: review?(neil) → review+
(In reply to comment #4)
> (From update of attachment 258964 [details] [diff] [review])
> Doesn't the Languages panel need to go too?
> 
If I remember correctly Robert said it needed reworking into something else.

Comment 6

10 years ago
Right. We need our languages panel as long as bug 377881 is open - I'd love to get that one fixed and remove our language switching panel as well.
Patch checked in. Fixed.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Comment 8

10 years ago
Sorry, should have mentioned we need amend help references to themes. Do you want that done as a separate bug?
(In reply to comment #8)
> Sorry, should have mentioned we need amend help references to themes. Do you
> want that done as a separate bug?
> 
Yeah, probably should block 373359 on that as well.
You need to log in before you can comment on or make changes to this bug.