372993 - Can't switch off proxy in connection settings

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Michael Peters]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.2) Gecko/20070219 Firefox/2.0.0.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.8.1.3pre) Gecko/20070305 Calendar/0.5pre

I use a laptop in my office (with a proxy) and at home (without a proxy. I tried to change the connection settings from "Manual proxy configuration" to "direct connection to the internet". I can select the radio-button, but nothing changes. If i close the form and re-enter it, the radio-button "Manual proxy configuration" is selected again. 

Reproducible: Always

Steps to Reproduce:
1. Go to Options-Connection Settings-
2. Try to change the radio-buttons
3.



I tried to solve the problem on two systems (one with a new profile)!

Comment 1

[Simon Paquet [:sipaq]]

Confirming on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.3pre) Gecko/20070306 Calendar/0.5pre

I get the following error in the error console:

Error: syntax error
Source File: chrome://calendar/content/preferences/connection.js
Line: 172, Column: 3
Source Code:
  },

Comment 2

[Matthew (lilmatt) Willis]

I'm getting it on Mac too. 

Note that because of the preprocessing, the line number is deceiving.  Line 172 is actually the end of the doAutoconfigURLFixup function.

Comment 3

[Stefan Sitter [:ssitter]]

Attachment: rev0 - patch

The preprocessor removed the closing bracket in case of MOZILLA_1_8_BRANCH leading to the syntax error, this patch fixes this.

Comment 4

[Matthew (lilmatt) Willis]

Comment on attachment 257865 [details] [diff] [review]
rev0 - patch

Nice catch.

r=lilmatt

Comment 5

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED

Comment 6

[Michael Peters]

The problem is solved. Thanks for your quick help.