372997 - JavaScript warnings in attachment.js

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Henrik Gemal]

Warning: test for equality (==) mistyped as assignment (=)?
Source file: https://bugzilla.mozilla.org/js/attachment.js
Line: 96, Column: 52
Source code:
    if (element = document.getElementById('bigfile')) 


Warning: test for equality (==) mistyped as assignment (=)?
Source file: https://bugzilla.mozilla.org/js/attachment.js
Line: 98, Column: 54
Source code:
    if (element = document.getElementById('attachurl')) { 


Warning: test for equality (==) mistyped as assignment (=)?
Source file: https://bugzilla.mozilla.org/js/attachment.js
Line: 104, Column: 54
Source code:
    if (element = document.getElementById('isprivate'))

Comment 1

[Henrik Gemal]

Warning: assignment to undeclared variable thisfield
Source file: https://bugzilla.mozilla.org/js/attachment.js
Line: 76

Comment 2

[Reed Loden [:reed]]

Attachment: patch - v1

Add another set of parentheses to tell JS that we really want to use = over ==.

Comment 3

[Henrik Gemal]

remember to fix the thisfield warning too

Comment 4

[Reed Loden [:reed]]

tip:

Checking in js/attachment.js;
/cvsroot/mozilla/webtools/bugzilla/js/attachment.js,v  <--  attachment.js
new revision: 1.2; previous revision: 1.1
done

BUGZILLA-3_0-BRANCH:

Checking in js/attachment.js;
/cvsroot/mozilla/webtools/bugzilla/js/attachment.js,v  <--  attachment.js
new revision: 1.1.2.1; previous revision: 1.1
done

Comment 5

[Reed Loden [:reed]]

Attachment: second issue - patch - v1

Fix issue with 'i' and 'thisfield' variables.

Comment 6

[Henrik Gemal]

remember that there are both a thisfield in URLFieldHandler and DataFieldHandler function

Comment 7

[Reed Loden [:reed]]

(In reply to comment #6)
> remember that there are both a thisfield in URLFieldHandler and
> DataFieldHandler function

Yes, please read the patch. I fixed both. :)

Comment 8

[Reed Loden [:reed]]

tip:

Checking in js/attachment.js;
/cvsroot/mozilla/webtools/bugzilla/js/attachment.js,v  <--  attachment.js
new revision: 1.3; previous revision: 1.2
done

BUGZILLA-3_0-BRANCH:

Checking in js/attachment.js;
/cvsroot/mozilla/webtools/bugzilla/js/attachment.js,v  <--  attachment.js
new revision: 1.1.2.2; previous revision: 1.1.2.1
done