373014 - Search for public pages does not find all matches, but sandbox does

Status: RESOLVED WORKSFORME

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

1. Go to https://preview.addons.mozilla.org , log in and search for "chrome".
2. You see only one result.
3. Go to the sandbox (be sure having it enabled in your settings) and search again for "chrome".
4. You should see "Chrome List" in the results.
5. Click on it ( https://preview.addons.mozilla.org/de/firefox/addon/4453 )
6. Green install box and missing sandbox bar mark it as a public add-on.

ER: All add-ons should be found with public search.

Comment 1

[Andrei Hajdukewycz [:sancus]]

This is possibly a dupe of Bug 373310, but I'm not going to close this until preview is updated and we verify it.

Comment 2

[Oliver Saier]

Despite of your 6th point I'm 99.9% sure that Chrome List is in the sandbox, which is why it'll only show up when one searches for it in the sandbox. Having said that it may be annoying to search for a given addon then have to switch to sandbox and retry the search because that addon could possibly be in the sandbox (not to mention that public addons can't be found through sandbox searches either, and if you want to find /all/ addons that match a given search term, then you must search in both public and sandbox). Maybe the public search could return sandbox addons with a flag indicating their evilness.

Comment 3

[:Gijs (he/him)]

(In reply to comment #2)
> Despite of your 6th point I'm 99.9% sure that Chrome List is in the sandbox,
> which is why it'll only show up when one searches for it in the sandbox. <snip>

Actually, I'm guessing it's not, because when I was testing Remora I've approved it myself at some point. I'm not sure how the db was imported into preview.a.m.o, but it could be that it's not in the sandbox because of that. To be sure, check the actual database? If it's not in the sandbox, it should probably be moved there, if it *is* in the sandbox then the fact that all the styling is wrong is a separate bug.

I like your idea about the public search, fwiw. Maybe morph this bug then?

Comment 4

[Oliver Saier]

Yes so it's possible that approving an addon doesn't properly move it from the sandbox? I said I was almost sure it's still in the sandbox because it's not on "browse all public versions" either ( http://preview.addons.mozilla.org/en-US/firefox/browse/type:1/cat:all?page=2 ). Also my extension is exactly in the same case (not in public search etc.) and in the dev panel it's indicated "Extensions; In Sandbox; Public Nomination".

Comment 5

[Justin Scott [:fligtar]]

The Chrome List add-on is on the sandbox, but the file is public. That explains why the install button is green. (This is all listed in the Dev CP)

Gijs: Nominating and approving the add-on from the Dev CP should make the add-on public.