373121 - MozillaBuild doesn't do update-packaging correctly

Status: RESOLVED WORKSFORME

(Release Engineering :: General, defect, P3)

Description

[Benjamin Smedberg]

Attachment: Don't eval stuff with newlines, rev. 1

MozillaBuild doesn't do update-packaging correctly: it has something to do with newlines not being recognized by the shell. Anyway, this patch fixes it.

If we were using update-packaging on the branches (which I don't think we are?), we would need this there as well.

Comment 1

[Benjamin Smedberg]

Fixed on trunk. rhelmer, do these scripts on the tinderboxes/update machine auto-update, or do I need to ask someone to manually update them?

Comment 2

[Robert Helmer [:rhelmer]]

These should be checked out along with the build.

Comment 3

[Mike Kaply [:mkaply] (PTO until Sept 14)]

Attachment: 1.8 branch version of the patch

For posterity, the 1.8 version of the patch (slight modification)

I'm showing people how to use the update packaging on 1.8 branch for Firefox 2.

Comment 4

[(not reading, please use [e-mail] instead)]

fyi, this caused regression bug #375415

Comment 5

[[e-mail] (:bhearsum)]

Mass re-assign of MozillaBuild bugs into mozilla.org:MozillaBuild

Comment 6

[Robert Helmer [:rhelmer]]

(In reply to comment #4)
> fyi, this caused regression bug #375415

We took the patch in bug 375415, which presumably breaks this again.. I don't know of anyone doing partials on win32 though, so it's probably a better trade-off for now.

Comment 7

[Robert Helmer [:rhelmer]]

Just to clarify, we do need to do the following cross-platform:

* unwrap full update
* create full update

But currently we only create partials on Linux. This should be the current state..

Comment 8

[Benjamin Smedberg]

This is a release-engineering thing, not a mozillabuild thing. Did we switch to python scripts for MARs yet?

Comment 9

[Robert Helmer [:rhelmer]]

(In reply to comment #8)
> This is a release-engineering thing, not a mozillabuild thing. Did we switch to
> python scripts for MARs yet?

No, I don't think there was a bug specifically on that.. filed bug 444050 on it though. 

Comment 10

[Chris Cooper [:coop] (he/him)]

Mass move of bugs from Release Engineering:Future -> Release Engineering. See
http://coop.deadsquid.com/2010/02/kiss-the-future-goodbye/ for more details.

Comment 11

[Chris Cooper [:coop] (he/him)]

I have no problem creating the update tools on Windows now.