373196 - text selection with the mouse not working

Status: NEW

Description

[Tomeu Vizoso]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.8.1.2) Gecko/20060601 Firefox/2.0.0.2 (Ubuntu-edgy)
Build Identifier: 

Text in a webpage in gtkmozembed won't be selected by the mouse. Ctrl-A works. Easily reproducible in TestGtkEmbed.

Reproducible: Always

Steps to Reproduce:
Try to select some text on a webpage with the mouse.
Actual Results:  
Nothing happens.

Expected Results:  
The text would be selected and then could be copied, dragged, etc.

Comment 1

[Oleg Romashin (:romaxa)]

Created attachment 259826 [details] [diff] [review]
BUGFIX

Comment 2

[Oleg Romashin (:romaxa)]

Comment on attachment 259826 [details] [diff] [review]
BUGFIX

Just fixed default value state

Comment 3

[Christian Persch (GNOME) (away; not receiving bug mail)]

(Just something I noticed while looking at the patch:

from EmbedEventListener:

static PRInt32 sLongPressTimer = 0
[...]
#if 1
     if (sLongPressTimer)
       g_source_remove(sLongPressTimer);
 #else  
[...]
  sLongPressTimer = g_timeout_add(mLongMPressDelay, sLongMPress, mOwner->mOwningWidget);

First, g_timeout_add returns |guint|, NOT (signed) |int32|.
Second, sLongPressTimer isn't restored to 0 after g_source_remove.)

Comment 4

[Oleg Romashin (:romaxa)]

Probably we need to create some macro...
like:
#define GLIB_SOURCE_REMOVE(source) \
  PR_BEGIN_MACRO \
    if (source) { \
      g_source_remove(source); \
      source = 0; \
    } \
  PR_END_MACRO

And this stuff will be in branch very soon.

Comment 5

[timeless]

Comment on attachment 259826 [details] [diff] [review]
BUGFIX

assuming I'm understanding this code correctly, please rename return_val to handled.

Comment 6

[Priit Laes]

Created attachment 281782 [details] [diff] [review]
mouse-text-selection-bug-373196.patch

Updated patch trying to address comments from chpe and timeless. Also fixes the bug ;)

Any ETA we could get this to tree?

Comment 8

[Alexander Sack]

the attachment 281782 [details] [diff] [review] fixes it for me.

Comment 9

[timeless]

Comment on attachment 281782 [details] [diff] [review]
mouse-text-selection-bug-373196.patch

this patch is currently blocked by whatever patch that will reintroduce that code.