Closed
Bug 373207
Opened 18 years ago
Closed 18 years ago
l10n: rename entity / properties that changed due to bug #373211 (search.all.label, cmd.find.label, places.title, etc)
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
VERIFIED
FIXED
Firefox 3 alpha7
People
(Reporter: moco, Assigned: stevewon)
References
Details
Attachments
(2 files)
13.58 KB,
image/png
|
Details | |
7.51 KB,
patch
|
moco
:
review+
|
Details | Diff | Splinter Review |
"Search in Bookmarks & History" text should be "Search in Bookmarks", as we aren't going to expose history here, for FX 2.0 UI parity, right?
from http://lxr.mozilla.org/seamonkey/source/browser/locales/en-US/chrome/browser/places/places.properties#60
searchDefault=Search in Bookmarks & History
But, on a related note, history results are showing up. I'll log a bug about that, if we don't have one already.
Reporter | ||
Updated•18 years ago
|
Version: unspecified → Trunk
Reporter | ||
Comment 1•18 years ago
|
||
trivial patch coming for Fx 2 parity
Assignee: nobody → sspitzer
Summary: "Search in Bookmarks & History" text should be "Search in Bookmarks" → "Search in Bookmarks & History" text should be "Search in Bookmarks", "Places" window title should be Fx 2.0 "Bookmarks Manager"
Reporter | ||
Comment 2•18 years ago
|
||
joey has a fix for this one as well, see bug #373211
Assignee: sspitzer → jminta
Depends on: 373211
Reporter | ||
Comment 3•18 years ago
|
||
Reporter | ||
Comment 4•18 years ago
|
||
fixed as part of bug #373211.
thanks joey!
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 5•18 years ago
|
||
marek writes:
Stuff like this:
<!ENTITY places.title
- "Places">
+ "Bookmarks Manager">
and like this:
<!ENTITY cmd.find.label
- "Find in Bookmarks & History...">
+ "Find in Bookmarks...">
and like this:
<!ENTITY search.all.label
- "All Bookmarks and History">
+ "All Bookmarks">
are semantic changes that require changing the entity name as well.
he's right, I'll fix that.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 6•18 years ago
|
||
No, not as long as places-bookmarks are NPOB.
Status: REOPENED → RESOLVED
Closed: 18 years ago → 18 years ago
Resolution: --- → FIXED
Comment 7•18 years ago
|
||
As far as l10n is concerned, there is not NPOB.
That's why I keep suggesting to put l10n files that aren't ready for our localizers out of the locale/en-US directories.
Places of course it particularily evil, as it was already partially localized during it's pre-1.5 stages.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 8•18 years ago
|
||
Axel, whenever we turn on places-bookmark UI again, localizers would have to review their entire strings set for places, not only strings we tweaked/changed recently.
If you would like to see the locale files for places moved out of locales/ until finalized, please file a bug. I can spare few cycles on it if it helps localizers.
Status: REOPENED → RESOLVED
Closed: 18 years ago → 18 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 9•18 years ago
|
||
reopening this particular issue on these particular strings based on discussion in axel's l10n meeting today in #places.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Comment 10•18 years ago
|
||
taking to address comment #5
Assignee: jminta → sspitzer
Status: REOPENED → NEW
Reporter | ||
Comment 11•18 years ago
|
||
l10n impact, so beta 1, updating summary, over to nobody
Assignee: sspitzer → nobody
Flags: blocking-firefox3?
OS: Windows XP → All
Hardware: PC → All
Summary: "Search in Bookmarks & History" text should be "Search in Bookmarks", "Places" window title should be Fx 2.0 "Bookmarks Manager" → l10n: rename entity / properties that changed due to bug #373211 (search.all.label, cmd.find.label, places.title, etc)
Target Milestone: --- → Firefox 3 beta1
Updated•18 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
Reporter | ||
Comment 12•18 years ago
|
||
note to steve, who might be taking this:
take a look at the fix for bug #373211
I made some string changes to both .properties and .dtd
and unless it is a simple whitespace, typo, or punctuation change
we need to rename the entity / property name
otherwise, localizer won't know things have changed
so we need to figure out what I did (or joey did) and fix those entities / properties
Assignee | ||
Updated•18 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•18 years ago
|
Assignee: nobody → swon
Status: ASSIGNED → NEW
Assignee | ||
Comment 13•18 years ago
|
||
Hey Seth. Sorry this took so long. I took it up on Tuesday, but didn't get to touch it until this morning.
Attachment #271082 -
Flags: review?(sspitzer)
Assignee | ||
Updated•18 years ago
|
Status: NEW → ASSIGNED
Reporter | ||
Comment 14•18 years ago
|
||
Comment on attachment 271082 [details] [diff] [review]
Patch
r=sspitzer, thanks steve for this cleanup (which will help our localizers).
I'll land as soon as the tree opens.
Attachment #271082 -
Flags: review?(sspitzer) → review+
Reporter | ||
Comment 15•18 years ago
|
||
fixed. Thanks again Steve for fixing this before beta 1.
Checking in browser/components/places/content/places.js;
/cvsroot/mozilla/browser/components/places/content/places.js,v <-- places.js
new revision: 1.92; previous revision: 1.91
done
Checking in browser/components/places/content/places.xul;
/cvsroot/mozilla/browser/components/places/content/places.xul,v <-- places.xul
new revision: 1.76; previous revision: 1.75
done
Checking in browser/locales/en-US/chrome/browser/places/places.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/places/places.dtd,v <--
places.dtd
new revision: 1.25; previous revision: 1.24
done
Checking in browser/locales/en-US/chrome/browser/places/places.properties;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/places/places.properties,v
<-- places.properties
new revision: 1.20; previous revision: 1.19
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago → 18 years ago
Resolution: --- → FIXED
Comment 16•18 years ago
|
||
verified with: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007071805 Minefield/3.0a7pre
Status: RESOLVED → VERIFIED
Comment 17•15 years ago
|
||
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".
In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body contains places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.
Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.
Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•