373240 - Uppercase the VK_* bits for consistency with the rest of the codebase

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Serge Gautherie (:sgautherie)]

While working on bug 283182, I noticed this part of the fix from bug 295721:
vk_* -> VK_*.

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) </xpfe/*> [Checkin: Comment 3]

Uppercasing,
and whitespace nits.

Comment 2

[[e-mail]]

Comment on attachment 257881 [details] [diff] [review]
(Av1) </xpfe/*>
[Checkin: Comment 3]

Looks OK but I don't see the point as these files won't be used once everyone switches to toolkit.

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 257881 [details] [diff] [review]
(Av1) </xpfe/*>
[Checkin: Comment 3]


Checkin: {
2007-03-09 08:43	bugzilla%standard8.demon.co.uk
}

Comment 4

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) </browser/*> [Checkin: Comment 11]

Uppercasing,
and whitespace nits.

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1) </mailnews/*> [Checkin: Comment 18]

Uppercasing,
and lots of whitespace nits,
and a few "rewrites".

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 258256 [details] [diff] [review]
(Cv1) </mailnews/*>
[Checkin: Comment 18]

I'd prefer it if Neil or David checks this - they have more experience in the general mailnews area.

Comment 7

[[e-mail]]

Comment on attachment 258256 [details] [diff] [review]
(Cv1) </mailnews/*>
[Checkin: Comment 18]

Actually Scott's the best reviewer for this file.

Comment 8

[Scott MacGregor]

Comment on attachment 258256 [details] [diff] [review]
(Cv1) </mailnews/*>
[Checkin: Comment 18]

actually I think I was too hasty in this. I could only see white space changes when I read through the patch but I suspect there may be some non white space changes lurking here. Can you post a patch that doesn't include the white space cleanup?

Comment 9

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1-Bw) </mailnews/*> (for review only)

Comment 10

[Scott MacGregor]

Comment on attachment 258408 [details] [diff] [review]
(Cv1-Bw) </mailnews/*> (for review only)

Ah excellent, thanks for doing that.

I thought I read somewhere that the '.' should stay on the first line. I think it was in an mkaply blog post about  operator:

+          var pref = Components.classes["@mozilla.org/preferences-service;1"]
+                               .getService(Components.interfaces.nsIPrefBranch);

Comment 11

[Serge Gautherie (:sgautherie)]

Comment on attachment 258205 [details] [diff] [review]
(Bv1) </browser/*>
[Checkin: Comment 11]


Checkin: {
2007-03-13 11:56	bugzilla%standard8.demon.co.uk 	mozilla/browser/components/search/content/search.xml 	1.94
}

Comment 12

[Serge Gautherie (:sgautherie)]

Attachment: (Dv1) </layout/*> [Checkin: Comment 19]

Uppercasing,
and whitespace nits,
and a "rewrite".

Comment 13

[Serge Gautherie (:sgautherie)]

(In reply to comment #10)
> I thought I read somewhere that the '.' should stay on the first line.

I found
{{
Note that there is one construct that JSLint complains about that is very common in Mozillla/Firefox source code:
...
JSLint would prefer you wrote it like this (note the location of the period)
...
I went ahead and made this change in my code to avoid seeing the JSLint errors, but your mileage may very.
}}
at <http://www.kaply.com/weblog/category/operator/page/2/>.
See "Line-Ending Punctuators" at <http://www.jslint.com/lint.html> for details.

Do you want me to update my patch, or is it all right to check it in as it is ?

Comment 14

[Scott MacGregor]

I don't need to see a new patch. Thanks Serge.

Comment 15

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 258482 [details] [diff] [review]
(Dv1) </layout/*>
[Checkin: Comment 19]

r+sr=dbaron, although I think this file is unused.  In the future, please don't mix whitespace cleanup with other patches; it makes reviewing harder.

Comment 16

[Serge Gautherie (:sgautherie)]

(In reply to comment #15)
> (From update of attachment 258482 [details] [diff] [review])
> r+sr=dbaron, although I think this file is unused.

It would seem so:
<http://lxr.mozilla.org/mozilla/search?string=select.xml>
{{
select.xml

/layout/forms/resources/jar.mn, line 4 -- content/forms/select.xml (content/select.xml)
/layout/forms/resources/content/xbl-forms.css, line 42 -- -moz-binding: url("chrome://forms/content/select.xml#select-size");
/layout/forms/resources/content/xbl-forms.css, line 49 -- -moz-binding: url("chrome://forms/content/select.xml#select");
/layout/forms/resources/content/xbl-forms.css, line 63 -- -moz-binding: url("chrome://forms/content/select.xml#select-option");
/layout/forms/resources/content/xbl-forms.css, line 68 -- -moz-binding: url("chrome://forms/content/select.xml#select-optgroup");
/layout/forms/resources/content/xbl-forms.css, line 79 -- -moz-binding: url("chrome://forms/content/select.xml#select-treerows");
/layout/forms/resources/content/xbl-forms.css, line 83 -- -moz-binding: url("chrome://forms/content/select.xml#select-treebody");
}}

Probably due to bug 172288 !

I think it's worth updating the file.
Or should these files be removed from the Trunk ?

Comment 17

[Serge Gautherie (:sgautherie)]

David, see comment 16.

Comment 18

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

We might want it again in the future, so keep it.

Comment 19

[Serge Gautherie (:sgautherie)]

Comment on attachment 258256 [details] [diff] [review]
(Cv1) </mailnews/*>
[Checkin: Comment 18]


Checkin: {
2007-03-19 12:58	bugzilla%standard8.demon.co.uk 	mozilla/mailnews/base/resources/content/mailWidgets.xml 	1.113
}

Comment 20

[Serge Gautherie (:sgautherie)]

Comment on attachment 258482 [details] [diff] [review]
(Dv1) </layout/*>
[Checkin: Comment 19]


Checkin: {
2007-03-19 13:00	bugzilla%standard8.demon.co.uk 	mozilla/layout/forms/resources/content/select.xml 	1.34
}

Comment 21

[Serge Gautherie (:sgautherie)]

Attachment: (Ev1) </mail/*> [Checkin: Comment 24]

Uppercasing.

Comment 22

[Serge Gautherie (:sgautherie)]

Attachment: (Fv1) </widget/*> [Checkin: Comment 25]

Uppercasing.

Comment 23

[Josh Aas]

Comment on attachment 259154 [details] [diff] [review]
(Fv1) </widget/*>
[Checkin: Comment 25]

That is dead code (NPOB) and it is a comment change anyway, you shouldn't need sr for that.

Comment 24

[Mark Banner (:standard8)]

checked in Ev1:

Checking in mail/base/content/mailWindowOverlay.xul;
/cvsroot/mozilla/mail/base/content/mailWindowOverlay.xul,v  <--  mailWindowOverlay.xul
new revision: 1.203; previous revision: 1.202
done
Checking in mail/base/content/search.xml;
/cvsroot/mozilla/mail/base/content/search.xml,v  <--  search.xml
new revision: 1.14; previous revision: 1.13

Comment 25

[Mark Banner (:standard8)]

checked in Fv1:

Checking in widget/src/mac/nsMacEventHandler.cpp;
/cvsroot/mozilla/widget/src/mac/nsMacEventHandler.cpp,v  <--  nsMacEventHandler.cpp
new revision: 1.204; previous revision: 1.203

Comment 26

[Serge Gautherie (:sgautherie)]

Attachment: (Gv1) </toolkit/*> [Checkin: Comment 27]

Uppercasing,
and adding |;| to |this.selected = null| "lines".

Comment 27

[Serge Gautherie (:sgautherie)]

Comment on attachment 260228 [details] [diff] [review]
(Gv1) </toolkit/*>
[Checkin: Comment 27]


Checkin: {
2007-04-03 10:06	bugzilla%standard8.demon.co.uk
}