CompareLocales.py breaks on empty module dirs

RESOLVED FIXED

Status

Mozilla Localizations
Infrastructure
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: Pike, Assigned: Pike)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
We enabled (wrongly) sq mail on the branch, and it busted comparelocales (the python version) due to an empty mail dir.

Tracking the bustage fix here.
(Assignee)

Comment 1

11 years ago
Created attachment 257948 [details] [diff] [review]
wallpaper around empty dir, set up __iter__ to make next() fail good

We need to fake an empty inner iterator for an completely empty dir in __iter__.

I landed this patch on the trunk to fix the bustage, posthum review appreciated.
Attachment #257948 - Flags: review?(rcampbell)
Attachment #257948 - Flags: review?(rcampbell) → review+
(Assignee)

Comment 2

11 years ago
Thanks
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Updated

10 years ago
Component: Testing → Infrastructure
Product: Core → Mozilla Localizations
QA Contact: testing → infrastructure
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.