373340 - atom:logo in feed reading view

Status: VERIFIED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Franklin Tse]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a3pre) Gecko/20070309 Minefield/3.0a3pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a3pre) Gecko/20070309 Minefield/3.0a3pre

The feed reading view of Firefox does not currently display the image linked in <atom:logo>. However, it does display the image linked in the <image> element of RSS 2.

Reproducible: Always

Steps to Reproduce:
1.Load a feed that has a <logo> element in namespace "http://www.w3.org/2005/Atom"
2.Check if the image linked in <logo> is displayed
Actual Results:  
No image shown

Expected Results:  
The logo/image linked should be displayed

Comment 1

[Robert Sayre]

yes, a mistake on my part. we should fix this on trunk and try to get it in for 2.0.0.4.

Comment 2

[Robert Sayre]

Attachment: add atom:logo hooks

I missed this for no good reason in the initial impl :/

Comment 3

[Robert Sayre]

Attachment: add atom:logo hooks v2

Comment 4

[Asaf Romano (gone)]

Comment on attachment 259811 [details] [diff] [review]
add atom:logo hooks v2

>Index: src/FeedProcessor.js
>===================================================================

>+    // Resolve relative image links
>+    if (this.image && bagHasKey(this.image, "url")) {
>+      this._resolveImageLink();
>+    }
>+

nit: remove the braces.

r=mano.

Comment 5

[Robert Sayre]

Checking in src/FeedProcessor.js;
/cvsroot/mozilla/toolkit/components/feeds/src/FeedProcessor.js,v  <--  FeedProcessor.js
new revision: 1.24; previous revision: 1.23
done
Checking in test/xml/rfc4287/feed_logo.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/feed_logo.xml,v  <--  feed_logo.xml
new revision: 1.2; previous revision: 1.1
done

Comment 6

[Franklin Tse]

I will check whether the logo is displayed or not after the fix is added to latest trunk :)

Comment 7

[Franklin Tse]

Verified in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a4pre) Gecko/20070328 Minefield/3.0a4pre. Test with XML Base also.

Comment 8

[Franklin Tse]

Verified in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a4pre) Gecko/20070328 Minefield/3.0a4pre. Tested with XML Base also.

Comment 9

[Daniel Veditz [:dveditz]]

Comment on attachment 259811 [details] [diff] [review]
add atom:logo hooks v2

approved for 1.8.1.4, a=dveditz for release-drivers

Comment 10

[Robert Sayre]

Checking in src/FeedProcessor.js;
/cvsroot/mozilla/toolkit/components/feeds/src/FeedProcessor.js,v  <--  FeedProcessor.js
new revision: 1.1.2.17; previous revision: 1.1.2.16
done
Checking in test/xml/rfc4287/feed_logo.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/feed_logo.xml,v  <--  feed_logo.xml
new revision: 1.1.2.3; previous revision: 1.1.2.2
done

Comment 11

[Franklin Tse]

Verified in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4pre) Gecko/20070428 BonEcho/2.0.0.4pre