About and Credits dialog is very much too tall

RESOLVED FIXED in Thunderbird 3

Status

Thunderbird
Mail Window Front End
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: AlexIhrig, Assigned: philor)

Tracking

Trunk
Thunderbird 3

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments, 1 obsolete attachment)

(Reporter)

Description

11 years ago
Thunderbird 2.0pre 20070308 build

The about and credits dialog is very much too high. This looks ridiculous in an about dialog and should be fixed before the release.
Flags: blocking-thunderbird2?

Comment 1

11 years ago
This is the same height as the firefox about dialog. I believe it was changed as part of the license landing.
(Reporter)

Comment 2

11 years ago
Additional the credits dialog does nothing - no scrolling text.

Comment 3

11 years ago
(In reply to comment #2)
> Additional the credits dialog does nothing - no scrolling text.
> 

hmm, that's working for me on windows.
(Assignee)

Comment 4

11 years ago
(In reply to comment #1)
> I believe it was changed
> as part of the license landing.

By some incompetent hack who was supposed to notice that Fx also has a bigger image in about than in credits, so it doesn't look so... spacious.
Assignee: mscott → philringnalda

Comment 5

11 years ago
Scrolling working on linux. Doesn't look that high to me, but then I have a decent sized screen...

Comment 6

11 years ago
I downloaded a german build and the scrolling doesn't work there on Windows.
How strange. No errors in the console either.
(Reporter)

Comment 7

11 years ago
Created attachment 258016 [details]
About dialog
(Reporter)

Comment 8

11 years ago
1) I've tried the about/credits dialog with en-US credits.dtd and en-US about.dtd in the german Thunderbird build (repacked de.jar with the mentioned files) without success. So it shouldn't be a l10n problem of these files.

2) The dutch nl Thunderbird build has the same problems.
No scrolling on Russian build in Linux too.
Mozilla/5.0 (X11; U; Linux i686; ru; rv:1.8.1.3pre) Gecko/20070308 Thunderbird/2.0pre ID:2007030803
(Assignee)

Comment 10

11 years ago
And just to maximize confusion, I downloaded a de branch build, *did* get scrolling (in a new profile), noticed that the image on the first screen *was* larger, unlike my trunk build, and then went back to my trunk build and now it's larger too.
Created attachment 258023 [details]
Linux Screenshot (Polish)

This is how it looks for me. Scrolling works OK.
UA: Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.8.1.3pre) Gecko/20070309 Thunderbird/2.0pre

The spacing problem is not that bad if you have a bigger font, like I do (by default Linux/Gnome usually has bigger default font size than Windows).
Scrolling works OK here:
Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.8.1.3pre) Gecko/20070309 Thunderbird/2.0pre

Oops, the previous comment shouldn't have been added, sorry for bugspam. :)
(In reply to comment #9)
> No scrolling on Russian build in Linux too.
> Mozilla/5.0 (X11; U; Linux i686; ru; rv:1.8.1.3pre) Gecko/20070308
> Thunderbird/2.0pre ID:2007030803
> 
Huh, just downloaded lastest tinderbox build and scrolling works again. Sorry for false alarm.
(Assignee)

Comment 15

11 years ago
Okay, lack of scrolling was almost certainly bug 373181, so if you saw it, make sure you have a build from (well) after 17:01 Mozilla Standard Time 2007-03-08.

Moving the text down to the bottom of About I'll look at tonight, but the number of "this, that and the other cut off when I have something or that thing" bugs Firefox has had makes me leery at this point. Maybe it'll turn out to be something clean and clearly safe, though.

Comment 16

11 years ago
Nice detective work Phil. I was most worried about the scrolling issue as that could have been a show stopper. 
(Reporter)

Comment 17

11 years ago
Credits scrolling is working again in Thunderbird 2.0pre 20070309. Only the height should be fixed.
(Assignee)

Comment 18

11 years ago
Created attachment 258975 [details]
like so?

I'm running short of useful ideas: making the dialog smaller would only work if you remove some of the boilerplate at the end of credits.xhtml, since otherwise the license and contributor links go off the top, but I doubt that any of it is there just because it's so much fun to read; moving the text in the about page of the deck down to the bottom is as easy as changing the separator to a spacer, but as this screenshot shows, it's not a whole lot prettier, since you can't move the "Mozilla Thunderbird" part down, because it's actually in the image.
(Reporter)

Comment 19

11 years ago
(In reply to comment #18)
> Created an attachment (id=258975) [details]
> like so?

Oh no... then we should better change nothing.
(Assignee)

Comment 20

11 years ago
Created attachment 260560 [details] [diff] [review]
A little spacey, v.1

While this doesn't look like a top-notch designer carefully arranged it for pixel-perfection, it at least strikes me as an improvement.

For bonus points, I uncommented the preprocessed version number, and got rid of the hard-coded "3 alpha 1" - I didn't see quite why it was hard-coded, from the bug, but it's been worrying me since I first spotted it, being out of the usual batch of places where someone doing a release expects to change numbers.
Attachment #258975 - Attachment is obsolete: true
Attachment #260560 - Flags: review?(mscott)
(Assignee)

Comment 21

11 years ago
Created attachment 260562 [details]
Linux screenshot
(Assignee)

Comment 22

11 years ago
Created attachment 260563 [details]
Mac screenshot
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED
OS: Windows XP → All
Hardware: PC → All
Target Milestone: --- → Thunderbird 3
Version: 2.0 → Trunk

Comment 23

11 years ago
Comment on attachment 260560 [details] [diff] [review]
A little spacey, v.1

this looks great Phil. Thanks for cleaning up the hard coded alpha string too, I think it looks fine without it.
Attachment #260560 - Flags: review?(mscott) → review+
(Assignee)

Comment 24

11 years ago
mail/base/content/aboutDialog.xul: 1.21
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Updated

10 years ago
Flags: blocking-thunderbird2?
You need to log in before you can comment on or make changes to this bug.