373348 - Put the Help menu in an overlay (Help in Address Book top menu is named differently)

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.2) Gecko/20070219 Firefox/2.0.0.2
Build Identifier: http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2007-03-09-05-mozilla1.8.0/thunderbird-1.5.0.11pre.en-US.mac.dmg

The Help menu entries should be named consistently, instead of "Thunderbird Help" in the Address Book but "Mozilla Thunderbird Help" for the main UI.

Reproducible: Always

Steps to Reproduce:
1. Open up Address Book.
2. Click "Help" in the top menu.
3. The menu shows "Thunderbird Help" instead of "Mozilla Thunderbird Help" which appears in the main UI

Comment 1

[Mark Banner (:standard8)]

confirmed

Comment 2

[Scott MacGregor]

Attachment: fix for the trunk only

We might want to bump the entity names for the access keys as well to keep the names consistent.

Comment 3

[Magnus Melin [:mkmelin]]

The standalone msg window also uses brandShortName. 

But shouldn't it be full name in all places? 
Firefox uses full name for about, but not for the mac, wonder if that's a bug...
http://lxr.mozilla.org/seamonkey/source/browser/locales/en-US/chrome/browser/baseMenuOverlay.dtd#13

Comment 5

[Magnus Melin [:mkmelin]]

I'll take this.

Comment 6

[Magnus Melin [:mkmelin]]

"About ApplicationName. Opens your application’s About window, which contains copyright information and version number. (For more information, see “About Windows.” If you’ve specified a short name (see “The Application Menu Title”), use it in the About menu item; use the full application name in the About window."

<http://developer.apple.com/documentation/UserExperience/Conceptual/OSXHIGuidelines/XHIGMenus/chapter_17_section_4.html#//apple_ref/doc/uid/TP30000356-TPXREF108>

... so about comment 3 about firefox is not a bug..

I have a patch similar to that for firefox, bug 267227, so we get the help menu centralized into one place.

Comment 7

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Puts the Help menu into an overlay, like firefox in bug bug 267227.

I added F1 as help shortcut key on !mac. One problem with this patch, F1 does not work/show in the 3pane window but works fine for addressbook and standalone msg window. Anyone know what's up with that? 

The code is mostly copy-paste from the old version, and from firefox baseMenuOverlay. I have tested only on linux, is anybody able to test this on mac, and see if I got it right?

Comment 8

[Magnus Melin [:mkmelin]]

Got it working.

Comment 9

[Magnus Melin [:mkmelin]]

Attachment: proposed fix, v2

This patch
 - fixes the reported bug - use "&brandShortName; Help" everywhere
 - moves the help menu into an overlay
 - synch up with firefox for the openHelpMac keys
 - a couple of sw update functions had to move utilityOverlay.js (like firefox and sm), with minor adjustments

Would be great if you could test it on mac!

Comment 10

[Magnus Melin [:mkmelin]]

Oh, and adds F1 for help.

Comment 11

[Phil Ringnalda (:philor)]

Comment on attachment 311345 [details] [diff] [review]
proposed fix, v2

Nice, r=me. Just to prove I'm paying attention, a couple of the long lines in baseMenuOverlay.xul are easily wrapped to under 80 chars; please do.

Comment 12

[Magnus Melin [:mkmelin]]

Attachment: proposed fix, v3

Hmm, esp. now after bug 423486 the firefox help menu works the same as for thunderbird, might as well let the release notes be in the same order on all platforms (like firefox) and use "Help Contents" on non-macs.
http://lxr.mozilla.org/seamonkey/source/browser/base/content/baseMenuOverlay.xul

Or what do you think? (Changed that and two-three long lines.)

Comment 13

[Phil Ringnalda (:philor)]

Comment on attachment 311856 [details] [diff] [review]
proposed fix, v3

Nice catch, r=me

Comment 14

[Magnus Melin [:mkmelin]]

Checking in mail/base/jar.mn;
/cvsroot/mozilla/mail/base/jar.mn,v  <--  jar.mn
new revision: 1.106; previous revision: 1.105
done
RCS file: /cvsroot/mozilla/mail/base/content/baseMenuOverlay.xul,v
done
Checking in mail/base/content/baseMenuOverlay.xul;
/cvsroot/mozilla/mail/base/content/baseMenuOverlay.xul,v  <--  baseMenuOverlay.xul
initial revision: 1.1
done
Checking in mail/base/content/mailWindowOverlay.js;
/cvsroot/mozilla/mail/base/content/mailWindowOverlay.js,v  <--  mailWindowOverlay.js
new revision: 1.191; previous revision: 1.190
done
Checking in mail/base/content/mailWindowOverlay.xul;
/cvsroot/mozilla/mail/base/content/mailWindowOverlay.xul,v  <--  mailWindowOverlay.xul
new revision: 1.235; previous revision: 1.234
done
Checking in mail/base/content/utilityOverlay.js;
/cvsroot/mozilla/mail/base/content/utilityOverlay.js,v  <--  utilityOverlay.js
new revision: 1.5; previous revision: 1.4
done
Checking in mail/components/addrbook/content/addressbook.xul;
/cvsroot/mozilla/mail/components/addrbook/content/addressbook.xul,v  <--  addressbook.xul
new revision: 1.75; previous revision: 1.74
done
Checking in mail/components/compose/content/messengercompose.xul;
/cvsroot/mozilla/mail/components/compose/content/messengercompose.xul,v  <--  messengercompose.xul
new revision: 1.115; previous revision: 1.114
done
Checking in mail/locales/jar.mn;
/cvsroot/mozilla/mail/locales/jar.mn,v  <--  jar.mn
new revision: 1.53; previous revision: 1.52
done
RCS file: /cvsroot/mozilla/mail/locales/en-US/chrome/messenger/baseMenuOverlay.dtd,v
done
Checking in mail/locales/en-US/chrome/messenger/baseMenuOverlay.dtd;
/cvsroot/mozilla/mail/locales/en-US/chrome/messenger/baseMenuOverlay.dtd,v  <--  baseMenuOverlay.dtd
initial revision: 1.1
done
Checking in mail/locales/en-US/chrome/messenger/messenger.dtd;
/cvsroot/mozilla/mail/locales/en-US/chrome/messenger/messenger.dtd,v  <--  messenger.dtd
new revision: 1.72; previous revision: 1.71
done
Checking in mail/locales/en-US/chrome/messenger/addressbook/abMainWindow.dtd;
/cvsroot/mozilla/mail/locales/en-US/chrome/messenger/addressbook/abMainWindow.dtd,v  <--  abMainWindow.dtd
new revision: 1.13; previous revision: 1.12
done
Checking in mail/locales/en-US/chrome/messenger/messengercompose/messengercompose.dtd;
/cvsroot/mozilla/mail/locales/en-US/chrome/messenger/messengercompose/messengercompose.dtd,v  <--  messengercompose.dtd
new revision: 1.10; previous revision: 1.9
done

->FIXED