373381 - Rendering of radios/checkboxes with auto width has regressed

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Boris Zbarsky [:bzbarsky]]

STEPS TO REPRODUCE:  Load the testcase in the URL field

EXPECTED RESULTS: Radio button

ACTUAL RESULTS: Weird rectangular thing.  NOT round.

This regressed between 2007-02-06-01 and 2007-02-07-01.  Checkin range:

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=MozillaTinderboxAll&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-02-06+01%3A00%3A00&maxdate=2007-02-07+01%3A00%3A00&cvsroot=%2Fcvsroot

Looks like a regression from bug 177805 somehow...

This is making radio buttons pretty unusable whenever I hit sites that style them like that.

Comment 1

[Eli Friedman]

Aha, so that's why form control frames have a default width... ugh.

I'll have a patch sometime soon.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Then again, maybe we don't really care...

What do other browsers do here?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

If such sites exist, we should probably fix this.  After all, they ought to act like replaced elements.

Comment 4

[Eli Friedman]

Attachment: Patch

Blech, this is messy, but I think it's correct.

Comment 5

[Eli Friedman]

On a side note, why doesn't Linux have themed form controls?  (On Windows, to get this to show up I have to use <meta http-equiv="msthemecompatible" content="no">.)

Comment 6

[Robert Sayre]

please add a test for this, since it has slipped through the review process this time, and probably will again.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I had a patch to use themed form controls on Linux...
http://weblogs.mozillazine.org/roc/archives/2006/02/cairo_linux_and_gtk2_themes.html

We turned it off because it turns out most GTK2 themes look really bad when applied to HTML content. They tend to draw with the assumption that the underlying window has the GTK2 theme background color. For example, most Clearlooks-based themes draw text boxes with rounded corners by filling in the corners with what they presume is the window background color, which looks absolutely ugly when it isn't the background color, and in most HTML content it isn't.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 258067 [details] [diff] [review]
Patch

If your intent is to have a default border-box size of 13 pixels assuming a 2-pixel wide border, could you say so in a comment?

Comment 9

[Eli Friedman]

Attachment: Final patch

Fixed comment, and added a simple reftest.  (I'll check this in sometime soon.)

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 258140 [details] [diff] [review]
Final patch

>Index: reftests/bugs/373381-1.html
>+<meta http-equiv="msthemecompatible" content="no">

It's probably worth having a second test (and second reference) without that.

>+<input type="radio" style="width: auto">

You could add two more to the same test file (and then put two more unstyled in the reference):

<input type="radio" style="height: auto">
<input type="radio" style="height: auto; width: auto">

Comment 11

[Eli Friedman]

(In reply to comment #10)
> >+<input type="radio" style="width: auto">
> 
> You could add two more to the same test file (and then put two more unstyled in
> the reference):
> 
> <input type="radio" style="height: auto">
> <input type="radio" style="height: auto; width: auto">

Will do.

BTW, what exactly do we expect to happen if someone uses "height: 50px" on a checkbox?  IE and Fx with theming on Windows on put a square checkbox in 50px-high box, and Fx without theming draws a rectangular checkbox.  Hmm, I guess the way to fix it is to mess with how we draw checkboxes and radio buttons a bit.  (We also might want to address what to do if someone does "height: 50px; width: auto;", which could be different.)

> >+<meta http-equiv="msthemecompatible" content="no">
> 
> It's probably worth having a second test (and second reference) without that.

Okay... I'm actually running into issues with height: auto and themed checkboxes.  (Why only themed and only height?  I don't know.  I'll have to see if I can figure it out easily... probably some odd interaction between the border-box declaration, theming, and way the height gets computed.)  I guess I'll file another bug on it.

Comment 12

[Eli Friedman]

Checked in.

Filed Bug 373852 on the themed checkbox issue.