373570 - picking download new messages from account wizard causes "busy" alert

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[David :Bienvenu]

If you set up your initial pop3 account from the pop3 wizard, and pick "download new messages", you get an alert about the folder being busy on startup. This is because we're doing both a biff and a download new mail on startup.

Comment 1

[David :Bienvenu]

Attachment: possible fix

I haven't tried this patch (I'll try it right now, if I have time).

The idea is that if we're downloading the new account, there's not reason to biff on 3-pane startup.

Comment 2

[David :Bienvenu]

Comment on attachment 258230 [details] [diff] [review]
possible fix

clearing review request - this didn't fix it for me.

Comment 3

[David :Bienvenu]

Attachment: proposed fix

This does fix the issue - I didn't realize accountutils.js was clearing gNewAccountToLoad immediately, which was subverting my check for it later on.

Comment 4

[David :Bienvenu]

fixed on trunk and branch.  Cc'ing Neil in case SM needs a similar fix.

Comment 5

[[e-mail]]

So why doesn't gLoadStartFolder help?

Comment 6

[David :Bienvenu]

gLoadStartFolder is true in this case, I believe - we need the performBiff to be NOT run...that's why we check !gNewAccountToLoad , so that we won't do the performBiff if we are loading a new account.

We've always done this - but I made it put up an alert recently, to catch cases where the user tries to run a pop3 url when we're already busy doing something with the server. It would be better not to have an alert, but we also shouldn't try to do a biff and download new mail on startup.

Comment 7

[Karel Koubek]

It's interesting that I'd already mentioned this bug a long time ago and no one cared, see bug 368108. Probably it slipped under the radar, which is not so startling with so many bugs filled every day and I understand it. Please make it a dupe of this.

Comment 9

[[e-mail]]

Attachment: alternate approach

Comment 10

[[e-mail]]

Attachment: Safer patch

I don't clear gNewAccountToLoad because msgOpenAccountWizard already does.

Comment 11

[David :Bienvenu]

Comment on attachment 258845 [details] [diff] [review]
alternate approach

this looks ok to me - does this affect IMAP at all? Do we still load or not load the imap inbox? (I don't know what we do currently, though I suspect we load the inbox)

Comment 12

[Karsten Düsterloh]

I can't reproduce the actual bug (or more probably I just fail to understand how to provoke it), so there's no point in /me reviewing any patches here atm...

Comment 13

[Scott MacGregor]

Neil, were you going to back out the original fix on the trunk and land your alternative fix instead?

Comment 14

[Karsten Düsterloh]

Comment on attachment 258847 [details] [diff] [review]
Safer patch

Finally I found a way to provoke the problem - by creating the *first* account in a *fresh* profile!

Comment 15

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 258847 [details] [diff] [review]
Safer patch

a=me for next sm1.1.x