Closed
Bug 373614
Opened 18 years ago
Closed 18 years ago
Remove (deCOMtaminate) nsIXULContentSink
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha4
People
(Reporter: asqueella, Assigned: asqueella)
Details
Attachments
(1 file, 1 obsolete file)
21.45 KB,
patch
|
Details | Diff | Splinter Review |
Its only method, Init(), is only used in nsXULDocument.
I tried to avoid unnecessary changes in this patch, since I move lots of code.
Attachment #258277 -
Flags: superreview?(roc)
Attachment #258277 -
Flags: review?(Olli.Pettay)
Comment 1•18 years ago
|
||
Comment on attachment 258277 [details] [diff] [review]
patch
Please fix whatever jst-review complains about, all those seem to be valid in this case (or not sure about windows line endings)
http://beaufour.dk/jst-review/?patch=258277&file=
There is no reason to copy-paste extra whitespace or too long lines :)
Attachment #258277 -
Flags: review?(Olli.Pettay) → review+
Assignee | ||
Comment 2•18 years ago
|
||
The jst-review greasemonkey script broke with the update, so I now don't get a reminder to run it over the patches :(
Attachment #258277 -
Flags: superreview?(roc) → superreview+
Assignee | ||
Updated•18 years ago
|
Whiteboard: [checkin needed] - locally updated patch
Assignee | ||
Comment 3•18 years ago
|
||
This is what I'm going to check in once the re-build finishes.
Attachment #258277 -
Attachment is obsolete: true
Assignee | ||
Updated•18 years ago
|
Flags: in-testsuite-
Whiteboard: [checkin needed] - locally updated patch → [checkin needed]
Target Milestone: --- → mozilla1.9alpha4
Assignee | ||
Comment 4•18 years ago
|
||
mozilla/content/xul/document/public/Makefile.in 1.13
mozilla/content/xul/document/public/nsIXULContentSink.h delete
mozilla/content/xul/document/src/nsXULContentSink.cpp 1.180
mozilla/content/xul/document/src/nsXULContentSink.h 1.1
mozilla/content/xul/document/src/nsXULDocument.cpp 1.755
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•