Closed Bug 373648 Opened 17 years ago Closed 17 years ago

layout-debug location bar not visible on Firefox

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: sylvain.pasche, Assigned: sylvain.pasche)

Details

Attachments

(1 file, 1 obsolete file)

v2
1.14 KB, patch
Gavin
: review+
Details | Diff | Splinter Review
Attached patch v1 (obsolete) — — Splinter Review 
Window opened by toOpenWindowByType have a chromehidden="location" attribute by default, which hides the location bar.
Attachment #258296 - Flags: review?(dbaron)
Comment on attachment 258296 [details] [diff] [review]
v1

This is fine with me, although maybe it's better to drop the class="chromeclass-location"?  I don't know.  Maybe Gavin does.  But I don't think it matters much.
Attachment #258296 - Flags: review?(dbaron) → review+
I think it would be better to:
1) remove class="chromeclass-location" from the layoutdebug textbox. I suspect it's only there because someone copy/pasted it from a browser window. Opening a layout debug window without the location bar makes no sense.
2) File a bug on making toOpenWindowByType() use a better default feature set (I think "all,dialog=no" makes more sense, and matches the xpfe behavior after bug 136901).
Attached patch v2 — — Splinter Review 
I opened bug 373690 for the toOpenWindowByType enhancement.
Attachment #258296 - Attachment is obsolete: true
Attachment #258339 - Flags: review?(gavin.sharp)
Attachment #258339 - Flags: review?(gavin.sharp) → review+
Whiteboard: [checkin needed]
Assignee: nobody → sylvain.pasche
mozilla/extensions/layout-debug/ui/content/layoutdebug.xul  1.8
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: