373659 - checksetup.pl doesn't "check" the setup, it executes it

Status: RESOLVED WONTFIX

(Bugzilla :: Installation & Upgrading, defect, P5)

Description

[Joe Ogulin]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.10) Gecko/20070226 Fedora/1.5.0.10-1.fc6 Firefox/1.5.0.10 pango-text
Build Identifier: 

A script named "checksetup.pl" should not actually execute the setup without an explicit option specified by the administrator.  Your documentation erroneously says that you can run it over and over again to determine what needs to be done in order to upgrade.  Instead, if it finds all the perl modules, it actually executes the upgrade without letting the administrator say, "Go ahead and actually do it," instead of stating what needs to be done.

Reproducible: Always

Steps to Reproduce:
1. Run checksetup.pl

Actual Results:  
The database was upgraded without my consent/knowledge.

Expected Results:  
The perl installation and mysql database server are only checked for what needs to be done to install or upgrade.

Comment 1

[Max Kanat-Alexander]

Well, we could rename it to setup.pl. That would go along with the setup.cgi I plan to make.

Comment 2

[Joe Ogulin]

It would be nice to have one that just tests the setup and sees what needs to be done without actually executing it.

The impression I got from reading the notes with 2.22.1 were that it would only test the setup and see what needed to be done and how long it would take.  So I rather stupidly ran it, thinking it would tell me what needed to be done rather than actually do it.

Fortunately, the 2.18.4 -> 2.22.1 upgrade ran rather nicely and without a hitch. :)

Comment 3

[Max Kanat-Alexander]

(In reply to comment #2)
> It would be nice to have one that just tests the setup and sees what needs to
> be done without actually executing it.

  That's what the --check-modules switch is for. I'm pretty sure the installation instructions do explain to use that.

Comment 4

[Joe Ogulin]

But does it also check the database and say things like:

Need to upgrade table X:
   add column new_col

vs:

No database upgrades needed

The implication I get from "--check-modules" is that all it does is look at my perl setup and see what I'm missing.

Comment 5

[Max Kanat-Alexander]

(In reply to comment #4)
> The implication I get from "--check-modules" is that all it does is look at my
> perl setup and see what I'm missing.

  That's true, that's all it does. We'd never write a program to tell you whether or not you need to upgrade your database. It would be RIDICULOUSLY complex and gain you nothing. If you upgraded Bugzilla, you have to run checksetup.pl to finish the upgrade. That is, you always have to upgrade the database.

Comment 6

[Gervase Markham [:gerv]]

--check-modules fixes part of this, and the rest is WONTFIX as per comment 5.

Gerv