373669 - [FIX]FlushTags impls end update too late

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

As a result, we end up hitting UpdateChildCounts from nsContentSink::EndUpdate.

Although, given that EndUpdate can fire XBL constructors and those can modify the DOM, maybe we need to do this?   In that case, we need to fix HTMLContentSink::NotifyInsert too.  :(

Note that this is a trunk-only issue.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: This at least makes it consistent

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Same as diff -w

Same as diff -w.

But note what I said about XBL.  Scripts may have a similar issue.  It seems to me that ideally we would ignore Begin/EndUpdate if they're coming from our own call, so in this case the sequence would be to call the final EndUpdate() on the document, ignore the EndUpdate call from that on nsContentSink, and then decrement this notification counter _before_ the document processes XBL constructors and pending scripts.  This is probably not biting us right now because we flush out the sink before putting a script into the DOM...

Comment 3

[Boris Zbarsky [:bzbarsky]]

Checked in.  Filed bug 376761 on the remaining questions.