373709 - open the "Help" menu item in the places' based bookmarks manager dialog gives me a js error

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

open the "Help" menu item in the places' based bookmarks manager dialog gives me a js error

JavaScript error: chrome://browser/content/utilityOverlay.js, line 409: strings
has no properties

it appears that we can't find the bundle_browser string bundle.

Comment 1

[Joey Minta]

Attachment: adds the bundle

Adds the bundle to the places window.

Comment 2

[Phil Ringnalda (:philor)]

Isn't it already there? It wfm, like I'd expect, since places.xul is overlaid by chrome://browser/content/baseMenuOverlay.xul, and baseMenuOverlay.xul has the stringbundle. Am I missing something, or do we have some platform #ifdef I'm not seeing that makes it work on Mac and not on Windows?

Comment 3

[Joey Minta]

Comment on attachment 258449 [details] [diff] [review]
adds the bundle

whoops, there's just no overlay point for baseMenuOverlay to insert.  I'll submit a better patch shortly.

Comment 4

[Joey Minta]

Attachment: like so

Now baseMenuOverlay can actually put the string bundles in that it cares about.

Comment 5

[Asaf Romano (gone)]

Comment on attachment 258453 [details] [diff] [review]
like so

r=mano.

Comment 6

[Asaf Romano (gone)]

but please add a line break after the <script> element when checking it in.

Comment 7

[(not reading, please use [e-mail] instead)]

fix landed, thanks joey.

I added the line break after the <script> element, per asaf.

Checking in places.xul;
/cvsroot/mozilla/browser/components/places/content/places.xul,v  <--  places.xul

new revision: 1.68; previous revision: 1.67
done

Comment 8

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv