bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

open the "Help" menu item in the places' based bookmarks manager dialog gives me a js error

RESOLVED FIXED

Status

()

Firefox
Bookmarks & History
RESOLVED FIXED
12 years ago
9 years ago

People

(Reporter: (not reading, please use seth@sspitzer.org instead), Assigned: Joey Minta)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

open the "Help" menu item in the places' based bookmarks manager dialog gives me a js error

JavaScript error: chrome://browser/content/utilityOverlay.js, line 409: strings
has no properties

it appears that we can't find the bundle_browser string bundle.
(Assignee)

Comment 1

12 years ago
Created attachment 258449 [details] [diff] [review]
adds the bundle

Adds the bundle to the places window.
Assignee: nobody → jminta
Status: NEW → ASSIGNED
Attachment #258449 - Flags: review?(mano)
Isn't it already there? It wfm, like I'd expect, since places.xul is overlaid by chrome://browser/content/baseMenuOverlay.xul, and baseMenuOverlay.xul has the stringbundle. Am I missing something, or do we have some platform #ifdef I'm not seeing that makes it work on Mac and not on Windows?
(Assignee)

Comment 3

12 years ago
Comment on attachment 258449 [details] [diff] [review]
adds the bundle

whoops, there's just no overlay point for baseMenuOverlay to insert.  I'll submit a better patch shortly.
Attachment #258449 - Flags: review?(mano)
(Assignee)

Comment 4

12 years ago
Created attachment 258453 [details] [diff] [review]
like so

Now baseMenuOverlay can actually put the string bundles in that it cares about.
Attachment #258449 - Attachment is obsolete: true
Attachment #258453 - Flags: review?(mano)
but please add a line break after the <script> element when checking it in.
fix landed, thanks joey.

I added the line break after the <script> element, per asaf.

Checking in places.xul;
/cvsroot/mozilla/browser/components/places/content/places.xul,v  <--  places.xul

new revision: 1.68; previous revision: 1.67
done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.