Closed Bug 373772 Opened 15 years ago Closed 8 months ago

Unifying JSOP_(NUMBER|OBJECT|QNAMEPART|STRING)

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: igor, Unassigned)

Details

[This is a spin-off of bug 355736 comment 7]

Currently in SpiderMonkey JSOP_(NUMBER|OBJECT|QNAMEPART|STRING) are only different from the decompiler point of view, in the interpreter they all mean the same operation, to load an operand from atom's table on the stack. It would be nice to combine them into single JSOP_CONST for the price of an extra job in the decompiler.
Only JSOP_QNAMEPART needs a source note, SRC_UNQUOTE or some such. The rest can be handled via atom key tag discrimination.

/be
Assignee: general → igor
QA Contact: igor → general
I am not working on the bug.
Assignee: igor → general
Summary: Unifing JSOP_(NUMBER|OBJECT|QNAMEPART|STRING) → Unifying JSOP_(NUMBER|OBJECT|QNAMEPART|STRING)
Assignee: general → nobody

JSOp::Double and JSOp::String are now performing different actions, so there isn't anymore any reason to merge these opcodes.

Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.