373784 - mozillabuild's sed version doesn't support -i (inplace editing) and -u (unbuffered)

Status: RESOLVED FIXED

(Firefox Build System :: MozillaBuild, task)

Description

[Axel Hecht [:Pike]]

Ted's extensionwiz' build.sh uses sed -i, which apparently doesn't work on the sed 3.02 that msys ships. cygwin's  sed 4.1.5 is fine.

I guess there are a bunch of existing users of build.sh out there, it'd be nice if we could get a recent version of it. Not sure which version the Mac has, but my manpage claims support for -i there, too.

Comment 1

[[e-mail] (:bhearsum)]

Mass re-assign of MozillaBuild bugs into mozilla.org:MozillaBuild

Comment 2

[(not currently active) Ted Mielczarek]

I updated to msys-1.0.11-rc-1 and it still has an old sed. :-(

Comment 3

[Marco Bonardo [:mak]]

i have downloaded an msys version recently and it was versione 4.2.1
it has -i[SUFFIX]
it also has -r and -u that i use with Dolske's profile script to colorize pymake output.

Comment 4

[Marco Bonardo [:mak]]

http://sourceforge.net/projects/mingw/files/MSYS/sed/

Comment 5

[Marco Bonardo [:mak]]

http://sourceforge.net/projects/mingw/files/MSYS/sed/sed-4.2.1-2/sed-4.2.1-2-msys-1.0.13-bin.tar.lzma/download

Comment 6

[Marco Bonardo [:mak]]

Correction, the right version for us is this one

http://sourceforge.net/projects/mingw/files/MSYS/sed/sed-4.2.1-1/sed-4.2.1-1-msys-1.0.11-bin.tar.lzma/download

the -2 version requires msys 1.0.13 that has a new intl dll. the above one works just replacing the old one.

Comment 7

[Marco Bonardo [:mak]]

updated link:
http://sourceforge.net/projects/mingw/files/MSYS/BaseSystem/sed/sed-4.2.1-1/sed-4.2.1-1-msys-1.0.11-bin.tar.lzma/download

Comment 8

[Shawn Wilsher :sdwilsh]

can we maybe get this updated?

Comment 9

[Brian King [:kinger]]

Any news on this?

Comment 10

[(not currently active) Ted Mielczarek]

No, updating the MSYS components of MozillaBuild is really painful and tends to break things. :-/

Comment 11

[Myk Melez [:myk] [@mykmelez]]

Gaia's Makefile uses `sed -i`, so it doesn't work in MozillaBuild.  I worked around one instance in Gaia pull request 6096 <https://github.com/mozilla-b2g/gaia/pull/6096>, but there's a second instance I haven't resolved yet.  I might be able to work around that one too, but it'd be better to have `sed -i` in MozillaBuild.

Comment 12

[(not currently active) Ted Mielczarek]

This isn't any closer to getting fixed than it was 5 years ago, so you'd be better off using a workaround. (Why are people still writing sed in this day and age?)

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

http://downloads.sourceforge.net/project/mingw/MSYS/Base/sed/sed-4.2.1-1/sed-4.2.1-1-msys-1.0.11-bin.tar.lzma

Comment 14

[(no longer active)]

Can we include this new binary in the next mozilla-build release please?

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Why not.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/mozilla-build/rev/1053ca212330