Default Plug-in's InfoPlist.strings is a broken .strings file (typos)

VERIFIED FIXED

Status

()

Core
Plug-ins
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: Smokey Ardisson (offline for a while; not following bugs - do not email), Assigned: Smokey Ardisson (offline for a while; not following bugs - do not email))

Tracking

({verified1.8.1.4})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 258462 [details]
Corrected InfoPlist.strings

Default Plug-in's InfoPlist.strings file contains doubled double quotes at the beginning of two different strings, which throws errors in AppleGlot because the .strings file is not valid.

I don't think Firefox builds Default Plug-in, so it would be nice to get this on the branch if possible to cut down on the error noise our Camino l10n teams are seeing. 

(This is a UTF-16 file, as always, but cvs/bonsai/diff/etc. can't hack UTF-16, so it needs to pretend to be binary in all those cases.)
Attachment #258462 - Flags: review?(joshmoz)

Updated

10 years ago
Attachment #258462 - Flags: superreview?(sfraser_bugs)
Attachment #258462 - Flags: review?(joshmoz)
Attachment #258462 - Flags: review+

Comment 1

10 years ago
This is for the file at:

mozilla/modules/plugin/samples/default/mac/English.lproj/InfoPlist.strings

Updated

10 years ago
Attachment #258462 - Flags: superreview?(sfraser_bugs) → superreview?(pavlov)

Updated

10 years ago
Attachment #258462 - Flags: superreview?(pavlov) → superreview+

Comment 2

10 years ago
checked in on trunk
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Comment on attachment 258462 [details]
Corrected InfoPlist.strings

Requesting approval for the 1.8 branch on this patch to a default plug-in which Firefox doesn't currently build. afaict, this patch only affects Camino. See comment 1 for where it's located. Also note that it only changes a "" to a ".
Attachment #258462 - Flags: approval1.8.1.4?
Comment on attachment 258462 [details]
Corrected InfoPlist.strings

approved for 1.8.1.4, a=dveditz for release-drivers
Attachment #258462 - Flags: approval1.8.1.4? → approval1.8.1.4+
Whiteboard: [checkin needed]

Comment 5

10 years ago
Checked in on MOZILLA_1_8_BRANCH.

/cvsroot/mozilla/modules/plugin/samples/default/mac/English.lproj/InfoPlist.strings,v  <--  InfoPlist.strings
new revision: 1.2.76.1; previous revision: 1.2
Keywords: fixed1.8.1.4
Whiteboard: [checkin needed]
Verified on branch and trunk. Note again that this bug occurs in core but only affects Camino.
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1.4 → verified1.8.1.4
You need to log in before you can comment on or make changes to this bug.