373818 - Default Plug-in's InfoPlist.strings is a broken .strings file (typos)

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Corrected InfoPlist.strings

Default Plug-in's InfoPlist.strings file contains doubled double quotes at the beginning of two different strings, which throws errors in AppleGlot because the .strings file is not valid.

I don't think Firefox builds Default Plug-in, so it would be nice to get this on the branch if possible to cut down on the error noise our Camino l10n teams are seeing. 

(This is a UTF-16 file, as always, but cvs/bonsai/diff/etc. can't hack UTF-16, so it needs to pretend to be binary in all those cases.)

Comment 1

[Josh Aas]

This is for the file at:

mozilla/modules/plugin/samples/default/mac/English.lproj/InfoPlist.strings

Comment 2

[Josh Aas]

checked in on trunk

Comment 3

[Samuel Sidler (old account; do not CC)]

Comment on attachment 258462 [details]
Corrected InfoPlist.strings

Requesting approval for the 1.8 branch on this patch to a default plug-in which Firefox doesn't currently build. afaict, this patch only affects Camino. See comment 1 for where it's located. Also note that it only changes a "" to a ".

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 258462 [details]
Corrected InfoPlist.strings

approved for 1.8.1.4, a=dveditz for release-drivers

Comment 5

[froodian (Ian Leue)]

Checked in on MOZILLA_1_8_BRANCH.

/cvsroot/mozilla/modules/plugin/samples/default/mac/English.lproj/InfoPlist.strings,v  <--  InfoPlist.strings
new revision: 1.2.76.1; previous revision: 1.2

Comment 6

[Samuel Sidler (old account; do not CC)]

Verified on branch and trunk. Note again that this bug occurs in core but only affects Camino.