373838 - Implement browser-specific places tree view in JS

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Asaf Romano (gone)]

For the use of Firefox, we need its own variant of a places tree view. This implementation would also take care of annotations set by the firefox front-end (e.g. microsummaries).

I don't have a strong opinion on whether or not we should ship a basic implementation in toolkit (i.e. nsNavHistoryResultTreeViewer).

Comment 1

[Asaf Romano (gone)]

Attachment: wip

Comment 2

[Asaf Romano (gone)]

Attachment: more...

Comment 3

[Asaf Romano (gone)]

Attachment: more...

Comment 4

[Asaf Romano (gone)]

Attachment: typos and stuff

Comment 5

[Asaf Romano (gone)]

Attachment: stable

Comment 6

[Asaf Romano (gone)]

Attachment: remove c++ view

Comment 7

[(not reading, please use [e-mail] instead)]

been playing with both patches in my tree as I work on bug #369813, no problems yet, but:

+ isContainerEmpty: function PTV_isContainerOpen(aRow) {

shouldn't that be:

+ isContainerEmpty: function PTV_isContainerEmpty(aRow) {

Comment 8

[Asaf Romano (gone)]

copy-pasto.

Comment 9

[Dietrich Ayala (:dietrich)]

Comment on attachment 259166 [details] [diff] [review]
stable

a few nits:

>+  SESSION_STATUS_NONE: 0,
>+  SESSION_STATUS_START: 1,
>+  SESSION_STATUS_CONTINUE: 2,
>+  _getRowSessionStatus: function PTV__getRowSessionStatus(aRow) {
>+    this._ensureValidRow(aRow);
>+    var node = this._visibleElements[aRow];
>+    if (!PlacesUtils.nodeIsVisit(node))
>+      return this.SESSION_STATUS_NONE;
>+
>+    asVisit(node);
>+    if (node.sessionId != 0) {
>+      if (aRow == 0)
>+        return this.SESSION_STATUS_START;
>+
>+      var previousNode = this._visibleElements[aRow - 1];
>+      if (PlacesUtils.nodeIsVisit(previousNode) &&
>+          node.sessionId != asVisit(previousNode).sessionId)
>+        return this.SESSION_STATUS_START;
>+
>+      return this.SESSION_STATUS_CONTINUE;
>+    }

should return SESSION_STATUS_NONE here?

>+  },
>+
>+  _buildVisibleSection:
>+  function PTV__buildVisibleSelection(aContainer, aVisible, aVisibleStartIndex)

s/Selection/Section

>+      // repaint the region that stayed the same, also including the
>+      // container element itself since its twisty could have changed.
>+      var minLength;
>+      if (replaceCount > newElements.length)
>+        minLength = newElements.length;
>+      else
>+        minLength = replaceCount;
>+      this._tree.invalidateRange(startReplacement - 1,
>+                                 startReplacement + minLength - 1);

"stayed the same"? this comment should be reworded. or i'm misunderstanding what's going on here?

Comment 10

[Asaf Romano (gone)]

Attachment: as checked in

mozilla/browser/components/places/jar.mn 1.34
mozilla/browser/components/places/content/placesOverlay.xul 1.9
mozilla/browser/components/places/content/tree.xml 1.59
mozilla/browser/components/places/content/treeView.js initial revision: 1.1 (and 1.2)
mozilla/browser/components/places/content/utils.js 1.23
mozilla/toolkit/components/build/nsToolkitCompsCID.h 1.23
mozilla/toolkit/components/places/public/nsIFaviconService.idl 1.6
mozilla/toolkit/components/places/src/nsFaviconService.cpp 1.12
mozilla/toolkit/components/places/src/nsNavHistory.cpp 1.11
mozilla/toolkit/components/places/src/nsNavHistory.h 1.71
mozilla/toolkit/components/places/src/nsNavHistoryResult.cpp 1.83
mozilla/toolkit/components/places/src/nsNavHistoryResult.h 1.29
mozilla/toolkit/components/places/src/nsPlacesModule.cpp 1.3

Comment 11

[Dietrich Ayala (:dietrich)]

mano, is there anything in this change that needs tests?

Comment 12

[Gomita]

I found a trivial typo in:
http://mxr.mozilla.org/mozilla/source/browser/components/places/content/treeView.js#1271

s/PTV_selectionChnaged/PTV_selectionChanged/

Comment 13

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv