Closed
Bug 373918
Opened 17 years ago
Closed 17 years ago
gtk_moz_embed_get_nsIWebBrowser not in the glue
Categories
(Core Graveyard :: Embedding: GTK Widget, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9beta3
People
(Reporter: mpgritti, Assigned: asac)
Details
Attachments
(1 file, 1 obsolete file)
2.10 KB,
patch
|
benjamin
:
review+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
gtk_moz_embed_get_nsIWebBrowser is currently not exposed in the glue. That means there is no way for an embedding user to get access to the nsIWebBrowser wrapped by gtkmozembed (and so to the dom document etc).
romaxa: isn't this in the wrong file? /embedding/browser/gtk/src/gtkmozembed_internal.h, line 54 -- gtk_moz_embed_get_nsIWebBrowser, (GtkMozEmbed *embed,
Assignee: nobody → romaxa
Assignee | ||
Comment 2•17 years ago
|
||
microb backout removed the gtkmozembed_internal + the gtkmozembed_common symbols. This patch adds the internal ones.
Attachment #295042 -
Flags: review?(benjamin)
Comment 3•17 years ago
|
||
Comment on attachment 295042 [details] [diff] [review] include gtkmozembed_internal.h symbols in glue I don't think this is what we want... the internal functions may not be present in future versions of libxul, and so these functions would fail to load. Wouldn't it make more sense to have clients explicitly load the internal functions that they are using, *or*... load these functions by default, but don't make it an error if they don't load correctly?
Attachment #295042 -
Flags: review?(benjamin) → review-
Assignee | ||
Comment 4•17 years ago
|
||
Assignee: romaxa → asac
Attachment #295042 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #295228 -
Flags: review?(benjamin)
Updated•17 years ago
|
Attachment #295228 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 5•17 years ago
|
||
Comment on attachment 295228 [details] [diff] [review] introduce GTKEmbedStartupInternal asking approval1.9: _internal.h symbols are still frequently used by real-world gecko embedders.
Attachment #295228 -
Flags: approval1.9?
Updated•17 years ago
|
Attachment #295228 -
Flags: approval1.9? → approval1.9+
Updated•17 years ago
|
Keywords: checkin-needed
Comment 6•17 years ago
|
||
Checking in embedding/browser/gtk/src/gtkmozembed_glue.cpp; /cvsroot/mozilla/embedding/browser/gtk/src/gtkmozembed_glue.cpp,v <-- gtkmozembed_glue.cpp new revision: 1.9; previous revision: 1.8 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M11
Version: unspecified → Trunk
Updated•12 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•