373918 - gtk_moz_embed_get_nsIWebBrowser not in the glue

Status: RESOLVED FIXED

Description

[Marco Pesenti Gritti]

gtk_moz_embed_get_nsIWebBrowser is currently not exposed in the glue. That means there is no way for an embedding user to get access to the nsIWebBrowser wrapped by gtkmozembed (and so to the dom document etc).

Comment 1

[timeless]

romaxa: isn't this in the wrong file?
/embedding/browser/gtk/src/gtkmozembed_internal.h, 
line 54 -- gtk_moz_embed_get_nsIWebBrowser, (GtkMozEmbed *embed,

Comment 2

[Alexander Sack]

Created attachment 295042 [details] [diff] [review]
include gtkmozembed_internal.h symbols in glue

microb backout removed the gtkmozembed_internal + the gtkmozembed_common symbols. This patch adds the internal ones.

Comment 3

[Benjamin Smedberg]

Comment on attachment 295042 [details] [diff] [review]
include gtkmozembed_internal.h symbols in glue

I don't think this is what we want... the internal functions may not be present in future versions of libxul, and so these functions would fail to load.

Wouldn't it make more sense to have clients explicitly load the internal functions that they are using, *or*... load these functions by default, but don't make it an error if they don't load correctly?

Comment 4

[Alexander Sack]

Created attachment 295228 [details] [diff] [review]
introduce GTKEmbedStartupInternal

Comment 5

[Alexander Sack]

Comment on attachment 295228 [details] [diff] [review]
introduce GTKEmbedStartupInternal

asking approval1.9: _internal.h symbols are still frequently used by real-world gecko embedders.

Comment 6

[Reed Loden [:reed] (use needinfo?)]

Checking in embedding/browser/gtk/src/gtkmozembed_glue.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/gtkmozembed_glue.cpp,v  <--  gtkmozembed_glue.cpp
new revision: 1.9; previous revision: 1.8
done