373958 - Bootstrap weird characters check should send error response header

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Fred Wenzel [:wenzel]]

In bootstrap.php, a check for weird characters in the request URL is performed. When something unusual is found, the request is currently forwarded to the front page.

This can lead to strange results, when Firefox's XPI installer tries downloading a file (it fetches the front page and tries to handle it as a valid file). Instead, such an a failed attempt should return an HTTP error code, possibly "400 Bad Request".

Comment 1

[Fred Wenzel [:wenzel]]

Attachment: Send "bad request" response instead of forwarding to front page

Here's a fix for the issue. Does that seem okay?

Comment 2

[Fred Wenzel [:wenzel]]

Comment on attachment 274161 [details] [diff] [review]
Send "bad request" response instead of forwarding to front page

Wil, do you have time to review this?

Also, do you think that 400 Bad Request is the right error to throw here?

Comment 3

[Wil Clouser [:clouserw]]

Comment on attachment 274161 [details] [diff] [review]
Send "bad request" response instead of forwarding to front page

works for me

Comment 4

[Fred Wenzel [:wenzel]]

This is in the trunk, r6467, and will go online with the next push. Thanks.