373983 - Double click on fourth and following calendar opens New Calendar Wizard and not Properties dialog

Status: VERIFIED FIXED

(Calendar :: Lightning Only, defect)

Description

[Stefan Sitter [:ssitter]]

Using Thunderbird 2.0pre (20070313) with Lightning 0.5pre (2007031405)
and
Using Thunderbird 1.5.0.10 (20070221) with Lightning 0.3 (2006100618)

Double clicking on the fourth and following calendar in the Calendars tab in Lightning sidebar will open the New Calendar Wizard and not the Properties dialog as expected. Double clicking only works for the first to third calendar in list. For the fourth and following calendar it works by using the Edit button or context menu command.

Steps to Reproduce:
1. Create new Thunderbird profile and install Lightning
2. Switch to Calendars tab in Lightning sidebar
3. Create at least three more calendars
4. Double click calendar list entry to open Properties dialog for calendar

Actual Results:
For the first to third calendar in list the Properties dialog opens.
For the fourth and following calendars the New Calendar Wizard opens.

Expected Results:
Properties dialog should open for every calendar list entry.

Workaround:
Select calendar in list and use the Edit button or context menu command.

Comment 1

[Ted Milker]

Using Thunderbird 2.0.0.4 (20070604) and Lightning 0.7pre (2007071603) on Windows Vista, I see an off-by-one behavior.  With 5 calendars in my Calendars tab:

    Double clicking the first calendar results in a new calendar prompt.

    Double clicking the second calendar shows the first calendar in the tab properties.

    Double clicking the third calendar shows the second calendar in the tab properties.

    ... repeat above until space below last item ...

    Double clicking the space directly below the last calendar results in the last calendar's properties.

    Double clicking below that space results in a new calendar prompt.

Comment 2

[Ted Milker]

Build 2007072403 changed the way this bug works.  Now you cannot double click any of the calendars in the tree view.  This can be fixed by modifying ltnCalendarTreeView.onDoubleClick() in calendar-management.js on line 326:

var tree = document.getElementById("agenda-tree");

to

var tree = document.getElementById("calendarTree");

If this was not changed in 2007072403, this would explain the behavior in previous builds, since it was referring to the wrong tree.

I would submit a patch but it does not appear I can attach anything to this bug nor assign it to myself.

Comment 3

[Ted Milker]

Attachment: Updates incorrect tree id

This is against build 2007072403 but the fix is simple enough that it should apply to trunk or easily added by hand.

Comment 4

[Pete Riley]

Ted, thanks!, but it seems likely that Philipp will fix this as part of bug 388405. 

Comment 5

[Michael Büttner (no reviews TFN)]

Comment on attachment 273962 [details] [diff] [review]
Updates incorrect tree id

Daniel, I hope you don't mind me stealing the review request :-)

Comment 6

[Michael Büttner (no reviews TFN)]

Comment on attachment 273962 [details] [diff] [review]
Updates incorrect tree id

r=mickey.

Comment 7

[Michael Büttner (no reviews TFN)]

patch checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED

Comment 8

[Andreas Treumann]

Verified in lightning 2007073103 -> task is fixed.