Closed Bug 374013 Opened 17 years ago Closed 17 years ago

[FIXr]<input type=file> not populating previously selected file

Categories

(Core :: Layout: Form Controls, defect, P2)

Product:
Core
Component:
Layout: Form Controls
Platform:
x86
Windows XP
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9alpha8

People

(Reporter: BijuMailList, Assigned: bzbarsky)

Details

Attachments

(1 file)

Fix
1.04 KB, patch
sicking
: review+
sicking
: superreview+
dbaron
: approval1.9+
Details | Diff | Splinter Review 
On Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a3pre) Gecko/20070314 Minefield/3.0a3pre
<input type=file> is not populating previously selected file on the same control.

Steps:-
1. goto a web page with form having file upload
2. click "browse.." to select a digital camera photo file. 
3. before form submit assume that you accidentally 
   selected a file next to the one you really want.
4. click "browse..." again to select right file.
5. MS-Windows Common File Dialog should show with prev selected file.

expected result 
* prev selected file on same control should be shown

actual  result 
* prev selected file on same control NOT shown
Attached patch Fix — — Splinter Review 
sicking, want to review?  The two of us are to blame for this, so... ;)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #276235 - Flags: superreview?(jonas)
Attachment #276235 - Flags: review?(jonas)
Priority: -- → P2
Summary: <input type=file> not populating previously selected file → [FIX]<input type=file> not populating previously selected file
Target Milestone: --- → mozilla1.9 M9
Attachment #276235 - Flags: superreview?(jonas)
Attachment #276235 - Flags: superreview+
Attachment #276235 - Flags: review?(jonas)
Attachment #276235 - Flags: review+
Comment on attachment 276235 [details] [diff] [review]
Fix

Simple fix to QI the right node when looking for our currently-selected filename.  Minimal risk.
Attachment #276235 - Flags: approval1.9?
Summary: [FIX]<input type=file> not populating previously selected file → [FIXr]<input type=file> not populating previously selected file
Comment on attachment 276235 [details] [diff] [review]
Fix

a1.9=dbaron
Attachment #276235 - Flags: approval1.9? → approval1.9+
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.9 M9 → mozilla1.9 M8
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: