Closed Bug 374106 Opened 17 years ago Closed 17 years ago

E4X XMLList.contains halts execution when there is a complex match

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: jruderman, Assigned: igor)

Details

(Keywords: testcase, verified1.8.0.12, verified1.8.1.4)

Attachments

(1 file)

Fix
1.14 KB, patch
mrbkap
: review+
dveditz
: approval1.8.1.4+
dveditz
: approval1.8.0.12+
Details | Diff | Splinter Review 
js> <><x><y/></x></>.contains(<x><y/></x>); 3;

Result: no output
Expected: 3 (or an exception)
That was supposed to be fixed in bug 358965 :(
Assignee: general → igor
Attached patch Fix — — Splinter Review 
A trivial fix but asking Blake this time for a review.
Attachment #258704 - Flags: review?(mrbkap)
Attachment #258704 - Attachment is patch: true
Attachment #258704 - Attachment mime type: text/x-patch → text/plain
Attachment #258704 - Flags: review?(mrbkap) → review+
The fix should propagate to the branches.
Flags: blocking1.8.1.4?
Flags: blocking1.8.0.12?
I committed the patch from comment 2 to branches:

Checking in jsxml.c;
/cvsroot/mozilla/js/src/jsxml.c,v  <--  jsxml.c
new revision: 3.148; previous revision: 3.147
done
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Attachment #258704 - Flags: approval1.8.1.4?
Attachment #258704 - Flags: approval1.8.0.12?
Flags: blocking1.8.1.4?
Flags: blocking1.8.1.4+
Flags: blocking1.8.0.12?
Flags: blocking1.8.0.12+
/cvsroot/mozilla/js/tests/e4x/Regress/regress-374106.js,v  <--  regress-374106.js
initial revision: 1.1
Flags: in-testsuite+
fix bug number. sorry.
/cvsroot/mozilla/js/tests/e4x/Regress/regress-374116.js,v  <--  regress-374116.js
new revision: 1.2; previous revision: 1.1

Comment on attachment 258704 [details] [diff] [review]
Fix

approved for 1.8.1.4 and 1.8.0.12, a=dveditz for release-drivers
Attachment #258704 - Flags: approval1.8.1.4?
Attachment #258704 - Flags: approval1.8.1.4+
Attachment #258704 - Flags: approval1.8.0.12?
Attachment #258704 - Flags: approval1.8.0.12+
verified fixed 1.9.0 20070320 win/mac*/linux
Status: RESOLVED → VERIFIED
I committed the patch from comment 2 to MOZILLA_1_8_BRANCH:

Checking in jsxml.c;
/cvsroot/mozilla/js/src/jsxml.c,v  <--  jsxml.c
new revision: 3.50.2.62; previous revision: 3.50.2.61
done
Keywords: fixed1.8.1.4
I committed the patch from comment 2 to MOZILLA_1_8_0_BRANCH:

Checking in jsxml.c;
/cvsroot/mozilla/js/src/jsxml.c,v  <--  jsxml.c
new revision: 3.50.2.15.2.32; previous revision: 3.50.2.15.2.31
done
Keywords: fixed1.8.0.12
verified fixed linux, windows, mac* 1.8.0, 1.8.1 shell 20070406
Keywords: fixed1.8.0.12, fixed1.8.1.4 → verified1.8.0.12, verified1.8.1.4
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: