E4X XMLList.contains halts execution when there is a complex match

VERIFIED FIXED

Status

()

Core
JavaScript Engine
VERIFIED FIXED
11 years ago
11 years ago

People

(Reporter: Jesse Ruderman, Assigned: Igor Bukanov)

Tracking

({testcase, verified1.8.0.12, verified1.8.1.4})

Trunk
x86
Mac OS X
testcase, verified1.8.0.12, verified1.8.1.4
Points:
---
Bug Flags:
blocking1.8.1.4 +
blocking1.8.0.12 +
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
js> <><x><y/></x></>.contains(<x><y/></x>); 3;

Result: no output
Expected: 3 (or an exception)
(Assignee)

Comment 1

11 years ago
That was supposed to be fixed in bug 358965 :(
Assignee: general → igor
(Assignee)

Comment 2

11 years ago
Created attachment 258704 [details] [diff] [review]
Fix

A trivial fix but asking Blake this time for a review.
Attachment #258704 - Flags: review?(mrbkap)

Updated

11 years ago
Attachment #258704 - Attachment is patch: true
Attachment #258704 - Attachment mime type: text/x-patch → text/plain

Updated

11 years ago
Attachment #258704 - Flags: review?(mrbkap) → review+
(Assignee)

Comment 3

11 years ago
The fix should propagate to the branches.
Flags: blocking1.8.1.4?
Flags: blocking1.8.0.12?
(Assignee)

Comment 4

11 years ago
I committed the patch from comment 2 to branches:

Checking in jsxml.c;
/cvsroot/mozilla/js/src/jsxml.c,v  <--  jsxml.c
new revision: 3.148; previous revision: 3.147
done
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Updated

11 years ago
Attachment #258704 - Flags: approval1.8.1.4?
Attachment #258704 - Flags: approval1.8.0.12?
(Reporter)

Updated

11 years ago
Blocks: 374179
Flags: blocking1.8.1.4?
Flags: blocking1.8.1.4+
Flags: blocking1.8.0.12?
Flags: blocking1.8.0.12+

Comment 5

11 years ago
/cvsroot/mozilla/js/tests/e4x/Regress/regress-374106.js,v  <--  regress-374106.js
initial revision: 1.1
Flags: in-testsuite+

Comment 6

11 years ago
fix bug number. sorry.
/cvsroot/mozilla/js/tests/e4x/Regress/regress-374116.js,v  <--  regress-374116.js
new revision: 1.2; previous revision: 1.1
Comment on attachment 258704 [details] [diff] [review]
Fix

approved for 1.8.1.4 and 1.8.0.12, a=dveditz for release-drivers
Attachment #258704 - Flags: approval1.8.1.4?
Attachment #258704 - Flags: approval1.8.1.4+
Attachment #258704 - Flags: approval1.8.0.12?
Attachment #258704 - Flags: approval1.8.0.12+

Comment 8

11 years ago
verified fixed 1.9.0 20070320 win/mac*/linux
Status: RESOLVED → VERIFIED
(Assignee)

Comment 9

11 years ago
I committed the patch from comment 2 to MOZILLA_1_8_BRANCH:

Checking in jsxml.c;
/cvsroot/mozilla/js/src/jsxml.c,v  <--  jsxml.c
new revision: 3.50.2.62; previous revision: 3.50.2.61
done
Keywords: fixed1.8.1.4
(Assignee)

Comment 10

11 years ago
I committed the patch from comment 2 to MOZILLA_1_8_0_BRANCH:

Checking in jsxml.c;
/cvsroot/mozilla/js/src/jsxml.c,v  <--  jsxml.c
new revision: 3.50.2.15.2.32; previous revision: 3.50.2.15.2.31
done
Keywords: fixed1.8.0.12

Comment 11

11 years ago
verified fixed linux, windows, mac* 1.8.0, 1.8.1 shell 20070406
Keywords: fixed1.8.0.12, fixed1.8.1.4 → verified1.8.0.12, verified1.8.1.4
You need to log in before you can comment on or make changes to this bug.