374139 - --enable-places-bookmarks builds from the experimental tinderbox not working

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Dietrich Ayala (:dietrich)]

from bug 329964:

"I just tried the latest build from here:
http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/fxexp-win32-tbox-trunk/
and Import does not work, and there are no bookmarks at all, not even the
'default' ones.  Also, NO bookmarks can be created either thru drag&drop or
using Ctrl+D, a blank bookmark window shows up is the only action that appears
when trying to bookmark a page."


I tried the installer, and it looks like the bookmarks service is not available. Likely a packaging issue.

Comment 1

[bomfog]

(In reply to comment #0)
> I tried the installer, and it looks like the bookmarks service is not
> available. Likely a packaging issue.

I've been getting the same results with the zip builds, both nightly and hourly, fresh profile and safe mode, for at least several days (maybe a week?).

I had high hopes for sspitzer's checked-in hack for bug 373719 and bug 373721, but I found no sign of the check-in on http://tinderbox.mozilla.org/showbuilds.cgi?tree=MozillaExperimental . I've noticed the same thing with several of mano's check-ins. 

In cases like this, my default assumption is that I'm an idiot, and I'm looking in the wrong place or otherwise screwing up, but now I'm not so sure.

Sure would be nice to have bookmarks again :).

Comment 2

[Benjamin Smedberg]

You need to update browser/installer/windows/packages-static and browser/install/unix/packages-static to include any new files that you need to be shipped. You can do this without ifdefs, because if the file is missing we just issue a packaging warning and keep going.

Comment 3

[Mike Connor [:mconnor]]

nsLivemarkService.js is missing from packages-static, at least.  There's also no bookmarks.xpt being generated, but I think that's all in places.xpt now...

Comment 4

[bomfog]

For what it might be worth, as of "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a4pre) Gecko/2007040316 Minefield/3.0a4pre" at least partial bookmark-on-places functionality has returned--by which I am well pleased:)

Comment 5

[Dietrich Ayala (:dietrich)]

(In reply to comment #4)
> For what it might be worth, as of "Mozilla/5.0 (Windows; U; Windows NT 5.1;
> en-US; rv:1.9a4pre) Gecko/2007040316 Minefield/3.0a4pre" at least partial
> bookmark-on-places functionality has returned--by which I am well pleased:)
> 

Hi Michael, can you please provide some detail about what does and doesn't work for you?

Comment 6

[Dietrich Ayala (:dietrich)]

Attachment: add livemarks service to packages files

My windows installer/zip builds are crashing shortly after selecting a profile, so i haven't been able to debug this further. Here's a patch that adds the missing file mconnor commented on.

Comment 7

[(not reading, please use [e-mail] instead)]

Comment on attachment 260598 [details] [diff] [review]
add livemarks service to packages files

r=sspitzer

To confirm:

1)  there is nothing needed for mac, because we use a .dmg.

2) we don't need to wrap this with any sort of ifdef places.  (we don't wrap bin\components\places.xpt, so I'm guessing no.)

3)  are we forgetting anything else?  (I did a quick compare of my dist/bin/components/*.js vs what's in packages-static, and nothing places-like jumped out at me.)

Comment 8

[Dietrich Ayala (:dietrich)]

(In reply to comment #7)
> 2) we don't need to wrap this with any sort of ifdef places.  (we don't wrap
> bin\components\places.xpt, so I'm guessing no.)

actually, i'm not so sure about this. testing non-bookmarks build now..

Comment 9

[Benjamin Smedberg]

We do not need ifdefs for conditional files.

Comment 10

[Dietrich Ayala (:dietrich)]

Checking in browser/installer/unix/packages-static;
/cvsroot/mozilla/browser/installer/unix/packages-static,v  <--  packages-static
new revision: 1.92; previous revision: 1.91
done
Checking in browser/installer/windows/packages-static;
/cvsroot/mozilla/browser/installer/windows/packages-static,v  <--  packages-static
new revision: 1.103; previous revision: 1.102
done

Comment 11

[Jim Jeffery not reading bug-mail 1/2/11]

Looking at this tinderbox checkins, I don't see this patch. 
http://tinderbox.mozilla.org/MozillaExperimental/

I just tired the latest hourly build, and still no bookmarks show up.  If I'm impatient, sorry, or do we have to wait for a 'nightly' to pickup the build change?

Comment 12

[Dietrich Ayala (:dietrich)]

(In reply to comment #11)
> Looking at this tinderbox checkins, I don't see this patch. 
> http://tinderbox.mozilla.org/MozillaExperimental/
> 
> I just tired the latest hourly build, and still no bookmarks show up.  If I'm
> impatient, sorry, or do we have to wait for a 'nightly' to pickup the build
> change?
> 

Hi Jim, my change was not in that build, as I had only just checked in at the time that build finished.

I don't know what's up with the experimental box, i'll keep an eye on it and follow up if it doesn't get going.

Comment 13

[bomfog]

(In reply to comment #5)
> (In reply to comment #4)
> > For what it might be worth, as of "Mozilla/5.0 (Windows; U; Windows NT 5.1;
> > en-US; rv:1.9a4pre) Gecko/2007040316 Minefield/3.0a4pre" at least partial
> > bookmark-on-places functionality has returned--by which I am well pleased:)
> > 
> 
> Hi Michael, can you please provide some detail about what does and doesn't work
> for you?

Well, I just tried the latest hourly (4pm PDT) with a new profile, and it looks like everything that should be there might be there. I'm pretty sure that's changed since about noon, but I don't know why. As of 4pm, there hadn't been a check-in by you (nor obviously (to me) places-related) since a 10:21am check-in for bug #372501. Do changes go into the tree that don't show up at http://tinderbox.mozilla.org/MozillaExperimental/ ?

Back around noon, the morning build(s) were working with an old places.sqlite from mid-February, but not with the default newly-created file swapped in.

Off to see if I've achieved parity with the home-builders.

Comment 14

[bomfog]

WFM

Comment 15

[Tracy Walker [:tracy]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007080805 Minefield/3.0a8pre

places enabled builds have been working well for quite some time.

Comment 16

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv