Closed Bug 374149 Opened 17 years ago Closed 17 years ago

extension can't add to on exit handling prefs ui

Categories

(Thunderbird :: Account Manager, defect)

Product:
Thunderbird
Component:
Account Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Details

(Whiteboard: [jm-ex])

Attachments

(1 file)

proposed fix
688 bytes, patch
mscott
: superreview+
mscott
: approval-thunderbird2+
Details | Diff | Splinter Review
Attached patch proposed fix — — Splinter Review 
The on exit handling ui needs an id in its vbox so an extension can add to it.
Attachment #258738 - Flags: superreview?(mscott)
Attachment #258738 - Flags: approval-thunderbird2?
Comment on attachment 258738 [details] [diff] [review]
proposed fix

I think 'on' is usually associated with an event handler...onclick, etc. 

how about "exitHandlingBox" or "exitHandlingContainer" or something.
Attachment #258738 - Flags: superreview?(mscott)
Attachment #258738 - Flags: superreview+
Attachment #258738 - Flags: approval-thunderbird2?
Attachment #258738 - Flags: approval-thunderbird2+
Keywords: checkin-needed
David, care to land this? If you want me to land it for you, I can do that...
I can land this - I should change the name per Scott's suggestion.
(In reply to comment #3)
> I can land this - I should change the name per Scott's suggestion.

Ok, thanks!
Keywords: checkin-needed
Whiteboard: [needs landing]
Whiteboard: [needs landing] → [needs landing] [jm-ex]
landed with id exitHandlingBox
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
OS: Windows XP → All
Hardware: PC → All
Whiteboard: [needs landing] [jm-ex] → [jm-ex]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: