Closed Bug 374157 Opened 17 years ago Closed 10 years ago

Texts in Firefox credits is invisible or very difficult to read when using "High Contrast" theme

Categories

(Firefox :: Disability Access, defect)

Product:
Firefox
Component:
Disability Access
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: masa141421356, Unassigned)

References

Details

Attachments

(4 files, 1 obsolete file)

Screenshot of Trunk
14.53 KB, image/jpeg
Details
Patch v1
641 bytes, patch
Details | Diff | Splinter Review
Patch Using UserDefined colors
1.00 KB, patch
Details | Diff | Splinter Review
credits with Masahiro's patch applied.
44.25 KB, image/png
Details 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; ja; rv:1.8.1.2) Gecko/20070219 Firefox/2.0.0.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; ja; rv:1.8.1.2) Gecko/20070219 Firefox/2.0.0.2

At Firefox credit window(Help -> About Firefox -> Credits),
Backgroud Color is always White.
But Text color (other than "Friends" and "Contributors") depends on System Color.
When Using "HighContrast Black", Text Color is White, and is is invisible.



Reproducible: Always

Steps to Reproduce:
1.Set Windows System Color to "HighContrast Black"
2.Open "About Firefox" Window  (Help - About Firefox)
3.Push [Credits] Button
Actual Results:  
Texts is invisible.
See http://bugzilla.mozilla.gr.jp/attachment.cgi?id=3505

Expected Results:  
Texts should be visible.

I think there is diffrerent two solution.
1. Change text color to black.

2. Change background color to System Window Background Color.
   (But links is always BLUE. It can conflict with System Color. See Bug 371870).
It is reproducible too at
 Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a3pre) Gecko/20070309 Minefield/3.0a3pre.
Attached image Screenshot of Trunk — 

    
  
Blocks: themea11y

    
  
Summary: Texts in Credit is invisible when "3D Object Text Color" is white → Texts in Credit is invisible or very difficult to read when using "High Contrast" theme

    
    

    
  
This bug is caused by 
http://lxr.mozilla.org/mozilla1.8.0/source/browser/base/content/credits.xhtml.
background color of html element is white but font color is not defined.

Here is sample patch (Solution 1 at Comment #0 : Changing font color to black)
--- credits.xhtml
+++ credits.xhtml
@@ -10,24, +10,25 @@
     <!ENTITY % licenseDTD SYSTEM "chrome://global/locale/license.dtd">
     %licenseDTD;
   ]
 >
 
 
 <html xmlns="http://www.w3.org/1999/xhtml">
   <head>
     <title>&brandFullName; Credits</title>
 
     <style>
       html {
+        color: black;
         background-color: white;
       }
 
       * {
         cursor: default;
         -moz-user-select: none;
       }
 
       #titleBox {
         position: fixed;
         left: 0px;
         top: 0px;


    
    

    
  
(In reply to comment #3)

> @@ -10,24, +10,25 @@

Sorry, It should be @@ -42,24, +42,25 @@.


    
    

    
  
It seems to exist same problem in Thunderbird and Sunbird.
 http://lxr.mozilla.org/mozilla1.8.0/source/mail/base/content/credits.xhtml
 http://lxr.mozilla.org/mozilla1.8.0/source/calendar/sunbird/base/content/credits.xhtml

Should I file new bugs for Thunderbird and Sunbird?

    
  
Summary: Texts in Credit is invisible or very difficult to read when using "High Contrast" theme → Texts in Firefox credits is invisible or very difficult to read when using "High Contrast" theme

    
    

    
  
I filed 2 same problems of other products.
Thunderbird : Bug 375908
Calendar (Sunbird) : Bug 375910


    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch v1
        — 
          — Splinter Review
      

    


  
Assignee: nobody → bugzilla
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

        Attachment #261590 -
        Flags: review?

        Attachment #261590 -
        Flags: review? → review?(mano)

    
    

    
  
Comment on attachment 261590 [details] [diff] [review]
Patch v1

Hrm, why are the defaults here hardcoded/different from about:blank?

    
    

    
  
I didn't change the logic in the file. Looking at the code for about:blank, there aren't any colours set.

    
    

    
  
Comment on attachment 261590 [details] [diff] [review]
Patch v1

My point was that we might not want to hardcode the backgorund-color here at all (about:blank doesn't).

    
    

    
  
> (From update of attachment 261590 [details] [diff] [review])
> My point was that we might not want to hardcode the backgorund-color here at
> all (about:blank doesn't).
> 
When deleteing hardcoded background-color, hardcoded link color should be deleted or changed.
Bacause link color can conflict with System-background-color(see Bug 371870). 

http://lxr.mozilla.org/mozilla1.8.0/source/browser/base/content/credits.xhtml#136


    
    

    
  
Comment on attachment 261590 [details] [diff] [review]
Patch v1

Canceling review request until comment 10 is addressed.

        Attachment #261590 -
        Flags: review?(mano)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Alternative patch (obsolete)
        — 
          — Splinter Review
      

    


  
This patch removes hardcoded background-color and link-color from credits.xhtml

At Comment #0, I said
> 2. Change background color to System Window Background Color.
>   (But links is always BLUE. It can conflict with System Color. See Bug
371870).

But It is not true.
If links are NOT implemented by "A" element (i.e, SPAN element having onclick event handler), its color can conflict with system background color.
But all links in credits.xhtml are "A" element.
Color of "A" element can be chaged at "Tools --> Option".

    
    

    
  
(In reply to comment #13)
> Created an attachment (id=264207) [details]
> Alternative patch
> 

When applying default color rules of link, color of visited link is different from NON-visited link.
Is it good forFirefox credits?

OS: Windows 2000 → All
Hardware: PC → All

    
    

    
  


  

        Attachment #264207 -
        Attachment is obsolete: true

    
    

    
  


  
Looking at this screenshot, personally I think the patch from Simon should be used: hardcode the colors to go with the images. (I used the Firefox 2.0 credits dialog as an example, because I expect Firefox 3.0 to have the same images. Minefield uses different images what makes it look slightly better)

(In reply to comment #8)
> (From update of attachment 261590 [details] [diff] [review])
> Hrm, why are the defaults here hardcoded/different from about:blank?
> 

It looks like about:blank uses the colors set with the preferences from the content options panel. If you choose to use system colors for text and background, about:blank will be black on HighContrast Inverse/Black Themes.

Apparently those preferences don't apply to chrome (as in UI) content.

    
    

    
  
Back to nobody. I'm no longer interested in this bug.
Assignee: bugzilla → nobody
Status: ASSIGNED → NEW

    
    

    
  
Dialog has since been replaced.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: