374215 - Move all generally-useful Installation subroutines to Bugzilla::Install::Util

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, enhancement)

Description

[Max Kanat-Alexander]

Right now we have a few subroutines used during installation that are also used in other places in the Bugzilla code. These subroutines don't have any dependencies, so they should go into their own module that we can use anywhere.

The only difference between this and Bugzilla::Util is that it can also be reliably used at installation time, because it has no dependencies.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Okay, here we go. Everything that I could imagine being useful here has been moved into Install::Util. Eventually I'll want to refactor check_graphviz so that editparams.cgi can also use it, but not right now.

Comment 2

[Max Kanat-Alexander]

Okay, I've tested this code, it passes runtests, and it's a generally safe change. Granting approval myself and checking this in.

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.548; previous revision: 1.547
done
Checking in query.cgi;
/cvsroot/mozilla/webtools/bugzilla/query.cgi,v  <--  query.cgi
new revision: 1.173; previous revision: 1.172
done
Checking in Bugzilla/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB.pm,v  <--  DB.pm
new revision: 1.98; previous revision: 1.97
done
Checking in Bugzilla/Version.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Version.pm,v  <--  Version.pm
new revision: 1.13; previous revision: 1.12
done
Checking in Bugzilla/Install/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/DB.pm,v  <--  DB.pm
new revision: 1.30; previous revision: 1.29
done
Checking in Bugzilla/Install/Requirements.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Requirements.pm,v  <--  Requirements.pm
new revision: 1.30; previous revision: 1.29
done
RCS file: /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Util.pm,v
done
Checking in Bugzilla/Install/Util.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Util.pm,v  <--  Util.pm
initial revision: 1.1
done