374235 - Breakpad should replace Talkback in future versions of Sunbird

Status: VERIFIED FIXED

(Calendar :: Build Config, enhancement)

Description

[Omar Bajraszewski]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl-PL; rv:1.8.1.2) Gecko/20070219 Firefox/2.0.0.2
Build Identifier: 

There is a new crash- reporting client that will be integrated with Mozilla products. It should be included in Calendar roadmap...

Reproducible: Always

Comment 1

[Omar Bajraszewski]

As I understand the code is already built by default on Win32 (the exception handler is set in XRE_Main). Changes are needed in packages-static to package the breakpad client. Am I right? Something like this?:


; [Updater]
 bin\updater.exe
+
+; [crash reporter]
+bin\crashreporter.exe
+bin\crashreporter.ini


Patch from bug 368206 can be used to enable breakpad on the Mac.

Comment 2

[Martin Schröder [:mschroeder]]

I have a patch in hand to disable Talkback and enable Breakpad after the patches from bug 386925 will have been checked in.

Comment 3

[Martin Schröder [:mschroeder]]

Attachment: Disable Talkback on Trunk tinderboxen (also enable objdir on Win32 tinderbox)

This is the part one of replacing Talkback with Breakpad.

Comment 4

[Martin Schröder [:mschroeder]]

Attachment: Disable Talkback on Trunk tinderboxen (also enable objdir on Win32 tinderbox) v2

Added disable sending of crash reports on tinderboxen per environment variable.

Comment 5

[Martin Schröder [:mschroeder]]

Attachment: Enable Breakpad and remove Talkback leftovers

This patch is TRUNK only because not all files are in sync between MOZILLA_1_8_BRANCH and TRUNK. I'll file a follow-up bug for clean-up.

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 280353 [details] [diff] [review]
Enable Breakpad and remove Talkback leftovers

r=me on the build parts, I'm not really competent on the NSIS stuff, but it looks pretty sane.  FWIW, you'll still need a few more things in your tinder-config to actually enable symbol uploading, and you'll need some IT work to get a directory on stage to upload them to.  See bug 386726 for the SeaMonkey equivalent.

Comment 7

[(not currently active) Ted Mielczarek]

Oh, nevermind, I totally missed that bug that's set blocking this.

Comment 8

[Martin Schröder [:mschroeder]]

Comment on attachment 280353 [details] [diff] [review]
Enable Breakpad and remove Talkback leftovers

Requesting additional review for NSIS installer changes.

Comment 9

[Robert Strong (they/them - no direct email)]

Comment on attachment 280353 [details] [diff] [review]
Enable Breakpad and remove Talkback leftovers

>Index: calendar/installer/windows/nsis/installer.nsi
>===================================================================
>RCS file: /cvsroot/mozilla/calendar/installer/windows/nsis/installer.nsi,v
>retrieving revision 1.9
>diff -u -8 -p -r1.9 installer.nsi
>--- calendar/installer/windows/nsis/installer.nsi	16 Aug 2007 21:34:52 -0000	1.9
>+++ calendar/installer/windows/nsis/installer.nsi	10 Sep 2007 15:55:59 -0000
>@@ -774,38 +709,20 @@ Function preComponents
>   ${Unless} ${FileExists} "$EXEDIR\optional\extensions\[e-mail]"
>     Abort
>   ${EndUnless}
>   !insertmacro MUI_HEADER_TEXT "$(OPTIONAL_COMPONENTS_TITLE)" "$(OPTIONAL_COMPONENTS_SUBTITLE)"
>   !insertmacro MUI_INSTALLOPTIONS_DISPLAY "components.ini"
> FunctionEnd
> 
> Function leaveComponents
>-  ; If DOMi exists then it will be Field 2.
>-  ; If DOMi doesn't exist and talkback exists then TalkBack will be Field 2 but
>-  ; if DOMi doesn't exist we won't display this page anyways.
>-  StrCpy $R1 2
>-  ${If} ${FileExists} "$EXEDIR\optional\extensions\[e-mail]"
>-    ${MUI_INSTALLOPTIONS_READ} $R0 "components.ini" "Field $R1" "State"
>-    ; State will be 1 for checked and 0 for unchecked so we can use that to set
>-    ; the section flags for installation.
>-    SectionSetFlags 1 $R0
>-    IntOp $R1 $R1 + 1
>-  ${Else}
>-    SectionSetFlags 1 0 ; Disable install for DOMi
>-  ${EndIf}
>-
>-  ${If} ${FileExists} "$EXEDIR\optional\extensions\[e-mail]"
>-    ${MUI_INSTALLOPTIONS_READ} $R0 "components.ini" "Field $R1" "State"
>-    ; State will be 1 for checked and 0 for unchecked so we can use that to set
>-    ; the section flags for installation.
>-    SectionSetFlags 2 $R0
>-  ${Else}
>-    SectionSetFlags 2 0 ; Disable install for TalkBack
>-  ${EndIf}
>+  ${MUI_INSTALLOPTIONS_READ} $R0 "components.ini" "Field 2" "State"
>+  ; State will be 1 for checked and 0 for unchecked so we can use that to set
>+  ; the section flags for installation.
>+  SectionSetFlags 1 $R0
Use the following:
SectionSetFlags ${Section2} $R0

r=me for the installer portions with that changed.

I'm updating the common code in bug 392303 so it should be easier to get SunBird up to the latest changes in the other toolkit apps and to maintain going forward.

Comment 10

[Martin Schröder [:mschroeder]]

Attachment: Enable Breakpad and remove Talkback leftovers v2

Addressing nit. Carrying forward review.

Comment 11

[Martin Schröder [:mschroeder]]

Setting checkin-needed (TRUNK ONLY!).

Comment 12

[Stefan Sitter [:ssitter]]

(In reply to comment #11)
Does the patches need Module owner approval before?

Comment 13

[Martin Schröder [:mschroeder]]

(In reply to comment #12)
> (In reply to comment #11)
> Does the patches need Module owner approval before?
> 

Withdrawing checkin-needed.

Comment 14

[Martin Schröder [:mschroeder]]

Daniel, can you give an answer to comment#12?

Comment 15

[Daniel Boelzle [:dbo]]

I am ok with the changes; checked in on trunk.

Comment 16

[Martin Schröder [:mschroeder]]

Attachment: Clobber win32 trunk tinderbox to use objdir after distclean

We need to clobber the win32 trunk tinderbox to clean the srcdir and use a separate objdir.

Comment 17

[Daniel Boelzle [:dbo]]

Comment on attachment 280913 [details] [diff] [review]
Clobber win32 trunk tinderbox to use objdir after distclean

Checked in on HEAD.

Comment 18

[Martin Schröder [:mschroeder]]

Attachment: Disable crashreporter on tinderbox

Part from "Disable Talkback on Trunk tinderboxen (also enable objdir on Win32 tinderbox) v2" that has not been checked in.

Comment 19

[Martin Schröder [:mschroeder]]

Comment on attachment 280929 [details] [diff] [review]
Disable crashreporter on tinderbox

Daniel, can you check his in. It looks like you have checked in the old version with this part missing.

Comment 20

[Daniel Boelzle [:dbo]]

Checked in on HEAD.

Comment 21

[Martin Schröder [:mschroeder]]

We migrated from Talkback to Breakpad. I'll file separate bugs for problems that may appear. -> FIXED

Comment 22

[Omar Bajraszewski]

Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007092404 Calendar/0.6a1