Open Bug 374292 Opened 15 years ago Updated 6 months ago
Remove F7 keyboard shortcut for switching caret browsing on
Is there a legitimate use case for dynamic toggling of caret browsing? Furthermore, does this use case provide sufficient utility to override the disutility the shortcut provides to the thousands of users who accidentally enable it this way and can't figure out how to disable it? The warning dialog is not enough, as I'm sure MozillaZine support forum people could testify. I think the answer to these questions is no, and I've recently become motivated enough to actually do something about it.
Attachment #258871 - Flags: first-review?(mconnor)
Not disagreeing with you, just curious about the motivation. Juicy details?
(In reply to comment #0) > Is there a legitimate use case for dynamic toggling of caret browsing? I'm sure some people would argue that an accessibility feature that isn't easily accessible isn't of much use.
(note also bug 334169)
Easily accessible == in the preference window of whatever application is using the toolkit; if there isn't such a setting, then that's the application's problem, not the browser widget's problem. > (note also bug 334169) Options are useful when there's a genuine choice; I don't think there is one here.
It's used quite a bit. Keyboard-only users need to be able to select. I think the more important thing here is that the F7 setting is temporary and isn't remembered between sessions. See bug 194937. Mark Pilgrim was very close to getting that fixed, but he doesn't work on Mozilla anymore. The dialog pref would still persist, but F7 wouldn't. At least that takes care of the concern that people get it stuck on without realizing it, and it never gets turned off.
(In reply to comment #4) > Easily accessible == in the preference window of whatever application is using > the toolkit; if there isn't such a setting, then that's the application's > problem, not the browser widget's problem. That's not quite as easily accessible as a keyboard shortcut, of course. Perhaps instead of removing it entirely, we should just make it harder to hit accidentally. Requiring a modifier like Shift would do that, right? > > (note also bug 334169) > > Options are useful when there's a genuine choice; I don't think there is one > here. I wasn't suggesting we should fix that bug as it is currently summarized. I wanted to record the number in case we do end up fixing this bug, because then we could close that one. It also is an attempt at a solution to the same problem.
Are people accidentally enabling Caret Browsing because of the F7 keyboard shortcut, because of the vaguely worded pref, or some other way? If it's the keyboard shortcut, possible solutions other than removing the shortcut include making the change temporary (bug 194937) and making the dialog clearer (starting with bug 358970). Or maybe a different keyboard shortcut could be used that's harder to hit accidentally. If it's the pref, the pref should be reworded (bug 271420).
In my experienceat the various conferences I've attended over the years, I've had around 10 or so people show me a browser with caret mode on and wondering how to "fix it". In each case, the conclusion was they accidentally hit F7. They'd admitted to remembering a random dialog pop up around when it happened but hadn't bothered to read it.
There are editing systems like mozile that explicitly ask you to turn caret browsing on with F7. I think that if we remove the access key we should provide a way for web script to turn it on/off.
Christopher, I agree. I've found people with that mode on as well. That's why bug 194937 is so important.
Attachment #258871 - Flags: first-review?(mconnor) → review?(mconnor)
Making the binding configurable with addons like keyconfig should work for most use cases as well, I think. Here it's a buggy window manager (KDE4...) that wrongly sends the F7 to firefox when switching sessions via Ctrl-Alt-F7.
Note that bug 476897 added a pref that allows disabling the shortcut.
Comment on attachment 258871 [details] [diff] [review] Remove the binding From discussion, this isn't sufficient (and is probably bitrotted severely, but that's beside the point ;))
Attachment #258871 - Flags: review?(mconnor) → review-
You need to log in before you can comment on or make changes to this bug.