Closed Bug 374320 Opened 13 years ago Closed 13 years ago

Error Console misses an accesskey

Categories

(Toolkit Graveyard :: Error Console, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9alpha5

People

(Reporter: cedric.corazza, Assigned: cedric.corazza)

Details

(Keywords: access)

Attachments

(1 file, 2 obsolete files)

The "Evaluate" button misses an accesskey in the Error Console.
Before asking for a review, I would like to know what is the best option for accessibility : put the focus on the button itself or on the textbox it controls. Could an a11y people answer me?
Thanks.
The attached patch put the focus on the button at the moment.
Assignee: cedric.corazza → js-console
Component: JavaScript Debugger → Error Console
Product: Other Applications → Core
QA Contact: caillon → error-console
Attached patch Console patch v2 (obsolete) — Splinter Review
This one allows to put the focus either on the textbox or on the Evaluate button by adding a description label for the textbox.
I guess this is more accessible that way.
Tested on latest trunk nightly BuildID = "2007042104"
Assignee: js-console → cedric.corazza
Attachment #258904 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #262349 - Flags: review?
Chances are your review request will be ignored unless you specifically target it at a UI peer.

I don't know why they allow review requests without naming the reviewer, or why the default to nobody for a misspelling.
Comment on attachment 262349 [details] [diff] [review]
Console patch v2

Thanks for the tip Aaron. Actually, I had formerly asked for Gavin's review but I mispelled his bugzilla id.
Attachment #262349 - Flags: review? → review?(mconnor)
Comment on attachment 262349 [details] [diff] [review]
Console patch v2

Url: is wrong, I don't know why its being added, since its nut a Url...
Attachment #262349 - Flags: review?(mconnor) → review-
(In reply to comment #4)
> (From update of attachment 262349 [details] [diff] [review])
> Url: is wrong, I don't know why its being added, since its nut a Url...
> 
Right :\ . I didn't succeed to make this feature work so I don't even know what can be put in the textbox to evaluate. Should the label be "Code" ? Whatever it is, please just tell me and I will provide another patch with the right label and accesskey.
Thanks
Attached patch Console patch v3Splinter Review
Googling here and there, I found out that this textbox is used to evaluate chunks of code, so I guess "Code" should be appropriate as a label for this textbox.
Attachment #262349 - Attachment is obsolete: true
Attachment #264001 - Flags: review?
Attachment #264001 - Flags: review? → review?(mconnor)
Comment on attachment 264001 [details] [diff] [review]
Console patch v3

That'll do, for now.  I'm not sure its necessary at all, since you can just tab to the field.
Attachment #264001 - Flags: review?(mconnor) → review+
Whiteboard: [checkin needed]
(In reply to comment #7)
> [...] I'm not sure its necessary at all, since you can just tab
> to the field.

Yes, that's right when you open the Error Console, but if you travel through several messages within the error console with the keyboard, this will require several shift + tab to access the textbox field whithout accesskey. But I agree this is not a critical matter.
mozilla/toolkit/components/console/content/console.xul   1.13
mozilla/toolkit/locales/en-US/chrome/global/console.dtd  1.5
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → mozilla1.9alpha5
Version: unspecified → Trunk
Product: Core → SeaMonkey
Product: SeaMonkey → Toolkit
QA Contact: error-console → error.console
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.