374320 - Error Console misses an accesskey

Status: RESOLVED FIXED

(Toolkit Graveyard :: Error Console, defect)

Description

[Cédric Corazza]

Attachment: Patch adding accesskey to the "Evaluate" button

The "Evaluate" button misses an accesskey in the Error Console.
Before asking for a review, I would like to know what is the best option for accessibility : put the focus on the button itself or on the textbox it controls. Could an a11y people answer me?
Thanks.
The attached patch put the focus on the button at the moment.

Comment 1

[Cédric Corazza]

Attachment: Console patch v2

This one allows to put the focus either on the textbox or on the Evaluate button by adding a description label for the textbox.
I guess this is more accessible that way.
Tested on latest trunk nightly BuildID = "2007042104"

Comment 2

[Aaron Leventhal]

Chances are your review request will be ignored unless you specifically target it at a UI peer.

I don't know why they allow review requests without naming the reviewer, or why the default to nobody for a misspelling.

Comment 3

[Cédric Corazza]

Comment on attachment 262349 [details] [diff] [review]
Console patch v2

Thanks for the tip Aaron. Actually, I had formerly asked for Gavin's review but I mispelled his bugzilla id.

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 262349 [details] [diff] [review]
Console patch v2

Url: is wrong, I don't know why its being added, since its nut a Url...

Comment 5

[Cédric Corazza]

(In reply to comment #4)
> (From update of attachment 262349 [details] [diff] [review])
> Url: is wrong, I don't know why its being added, since its nut a Url...
> 
Right :\ . I didn't succeed to make this feature work so I don't even know what can be put in the textbox to evaluate. Should the label be "Code" ? Whatever it is, please just tell me and I will provide another patch with the right label and accesskey.
Thanks

Comment 6

[Cédric Corazza]

Attachment: Console patch v3

Googling here and there, I found out that this textbox is used to evaluate chunks of code, so I guess "Code" should be appropriate as a label for this textbox.

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 264001 [details] [diff] [review]
Console patch v3

That'll do, for now.  I'm not sure its necessary at all, since you can just tab to the field.

Comment 8

[Cédric Corazza]

(In reply to comment #7)
> [...] I'm not sure its necessary at all, since you can just tab
> to the field.

Yes, that's right when you open the Error Console, but if you travel through several messages within the error console with the keyboard, this will require several shift + tab to access the textbox field whithout accesskey. But I agree this is not a critical matter.

Comment 9

[Nickolay_Ponomarev]

mozilla/toolkit/components/console/content/console.xul   1.13
mozilla/toolkit/locales/en-US/chrome/global/console.dtd  1.5