374399 - nsMouseEvent->isMeta is not updated with others?

Status: RESOLVED INACTIVE

(Core :: Widget: Gtk, defect, P5)

Description

[Chongfeng Hu]

User-Agent:       Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1; .NET CLR 1.1.4322; .NET CLR 2.0.50727)
Build Identifier: firef0x 2.0.0.1

In widget/src/gtk2/nsWindow.cpp, I saw the following code:

void
nsWindow::OnMotionNotifyEvent(GtkWidget *aWidget, GdkEventMotion *aEvent)
{
...
        event.isShift   = (aEvent->state & GDK_SHIFT_MASK)                                                                                                      
            ? PR_TRUE : PR_FALSE;                                                                                                                               
        event.isControl = (aEvent->state & GDK_CONTROL_MASK)                                                                                                    
            ? PR_TRUE : PR_FALSE;                                                                                                                               
        event.isAlt     = (aEvent->state & GDK_MOD1_MASK)                                                                                                       
            ? PR_TRUE : PR_FALSE;
...
}

However, nsMouseEvent has 4 status indicators:

  /// PR_TRUE indicates the shift key is down
  PRBool          isShift;        
  /// PR_TRUE indicates the control key is down
  PRBool          isControl;
  /// PR_TRUE indicates the alt key is down
  PRBool          isAlt;          
  /// PR_TRUE indicates the meta key is down (or, on Mac, the Command key)
  PRBool          isMeta;

Why doesn't it update isMeta together with others here?

Reproducible: Always

Steps to Reproduce:
I found this place with the help of a code-analysis tool.

Comment 1

[Thomas Holaday]

There is a comment in msWindow::InitDragEvent: "GTK+ doesn't support the meta key."

Comment 2

[Thomas Holaday]

(In reply to comment #1)
> There is a comment in msWindow::InitDragEvent: "GTK+ doesn't support the meta
> key."
However, in GNOME Documentation here: ( http://library.gnome.org/devel/gdp-style-guide/2.23/gdp-style-guide.html ), there are definitions for both meta and meta key, which include the sentence "You can use the meta key as a modifier key."

The release notes for GNOME Commander ( http://www.gnomefiles.org/version.php?soft_id=1279 ) suggest that meta key support became available in GTK+ 2.1.

Comment 3

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1552613

Comment 4

[Sylvestre Ledru [:Sylvestre]]

no activity for years, closing.
Feel free to reopen if this is still occurring