374408 - don't ship nsTreeSorting with as part of the toolkit

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[Nickolay_Ponomarev]

see http://mxr.mozilla.org/seamonkey/search?string=treesorting

the browser/ hit appears to be bogus, i.e. history-panel.xul doesn't actually use nsTreeSorting's methods (although it's really hard to check).

Comment 1

[Worcester12345]

footprint key word

Comment 2

[Nickolay_Ponomarev]

OK, none of the functions in nsTreeSorting.js are used (and this version of history-panel will probably be replaced by the places-based version):

$ grep "function " nsTreeSorting.js 
function RefreshSort()
function SortInNewDirection(direction)
function SortColumn(columnId)
function SortColumnElement(column)
function find_sort_column()
function find_sort_direction(column)
function update_sort_menuitems(column, direction)
  // as this function may be called from various places, including the
function enable_sort_menuitems()
function fillViewMenu(popup)

$ egrep "RefreshSort|SortInNewDirection|SortColumn|SortColumnElement|find_sort_
column|find_sort_direction|update_sort_menuitems|enable_sort_menuitems|fillView
Menu|HistoryCommonInit" history.js history-panel.xul 

history.js:function HistoryCommonInit()
history-panel.xul:      onload="HistoryCommonInit();">

(The HistoryCommonInit bit is to check that my egrep-fu is not lacking)

Comment 3

[Nickolay_Ponomarev]

Attachment: remove from toolkit, mail, remove the bogus reference from history-panel.xul

Suiterunner still needs to be taken care of, but my build of that has not yet finished and it probably should be a separate patch anyway.

Comment 4

[Nickolay_Ponomarev]

Checked in without the mail/ part, which was fixed by somebody else.

Comment 5

[[e-mail]]

(In reply to comment #3)
>Suiterunner still needs to be taken care of, but my build of that has not yet
>finished and it probably should be a separate patch anyway.
A heads-up would have been nice...