374489 - after clicking a close button, double-clicking doesn't open a new tab until you move the mouse

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

1. open two tabs
2. click the close button of the second tab once or twice
3. wait
4. double click

Actual results: the second tab is closed but a new one isn't added.

Comment 2

[Asaf Romano (gone)]

Comment on attachment 259012 [details] [diff] [review]
patch

Sorry for latency.

You could simply this by setting a single click listener and checking event.detail (i.e. clickCount) in the listener.

I'm not yet sure why do you need the timer here.

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch v2

Ok, I think this should work then. Unfortunately I can't test this now. (The initial patch was successfully tested.)

As far as I remember, the timeout is needed because both this listener and the one that we want to block are now listening to the same event (and the latter is executed later), and we want to enable double-clicking for the /next/ time the event occurs.

Comment 4

[Dão Gottwald [:dao]]

Attachment: patch v2

was malformed

Comment 6

[Dão Gottwald [:dao]]

FWIW, v2 works as well, I've just tested it.

Comment 7

[Asaf Romano (gone)]

Comment on attachment 261560 [details] [diff] [review]
patch v2

hrm, with this patch, close a tab using its close button and click trice on the tabbar without moving the cursor (note: easier with a touch-pad).

Comment 8

[Dão Gottwald [:dao]]

(In reply to comment #7)
> [...] click trice on the tabbar [...]

A tab is opend and closed again. As far as I can tell, that's how it's been before, except for the case when you closed a tab and didn't move the mouse. I'd consider the latter a bug, as I don't think closing a tab and not moving the mouse should make triple clicking behave differently. If the general triple clicking behavior is flawed, that seems worth a separate bug.

Comment 9

[Dão Gottwald [:dao]]

(In reply to comment #8)
> A tab is opend and closed again. [...] If the general triple
> clicking behavior is flawed, that seems worth a separate bug.

-> now covered by bug 378344.

Comment 10

[Asaf Romano (gone)]

Comment on attachment 261560 [details] [diff] [review]
patch v2

r=mano

Comment 11

[Nickolay_Ponomarev]

Checking in tabbrowser.xml;
/cvsroot/mozilla/toolkit/content/widgets/tabbrowser.xml,v  <--  tabbrowser.xml
new revision: 1.226; previous revision: 1.225
done

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a9pre) Gecko/2007092705 Minefield/3.0a9pre

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

http://litmus.mozilla.org/show_test.cgi?id=4697

in-litmus+