374720 - Minor gfx changes to support new textframe work

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

See patch...

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: changes

-- Removing TextProvider as a superclass of PropertyProvider. It's no longer needed by nsTextFrameThebes

-- Make SetPotentialLineBreaks virtual so gfxTextRun subclasses can override it (text-transform:titlecase makes a special gfxTextRun subclass that changes its glyphs when potential line breaks change, because that means the start-of-word has changed).

-- Make SetLineBreaks virtual for similar reasons. Also make it return a boolean to say whether it changed anything or not.

-- Add ResetGlyphRuns and GetGlyphRuns so that other code can extract and update the glyph runs in a textrun.

-- Make SetDetailedGlyphs' aGlyphs parameter point to const

-- fix a bug in gfxPangoFont::Measure that indexes the spacing array incorrectly

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: update

All of the above, plus implement gfx(Atsui,Windows)FontGroup::Copy() (needed for smallcaps when we need to shrink the text size for a fontgroup).

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: oops, sorry

One more fix: comment out the assertion about glyph extents not being supported. It fires like crazy with the new textframe.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 5

[Paul Adenot (:padenot)]

Attachment: Handle self-connection

Thanks to some fuzzer-generated crashtest.

Comment 6

[Paul Adenot (:padenot)]

I'm not really sure what happened here, bzexport did something funny. Sorry for the noise.